New UserPreferencesManager implementation #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since NamedBeans, JavaBeans, and all code using properties in the UserPreferencesManager all use Strings to identify properties, only use Strings here as well. Also use constants for fired property changes.
This allows UI preferences to be stored and updated as needed instead of only once in a shutdown hook.
This implementation uses the same preferences/configuration storage mechanism as the explicit preferences do.
- Allow other parts of JMRI to be aware of a shutdown in progress. - Fix FindBugs warnings. - Use boolean instead of Boolean to indicate shutdown failure. - Close open windows with a WindowClosing event instead of an immediate dispose().
Do not ask a user if its okay to shutdown after shutdown has started.
Since some tests of other code explicitly call out the old manager (instead of only using the API that UI managers implement): - trap settings in old manager within the new manager, instead of only at file read time - allow test implementations to override showMessage to prevent tests from waiting on user input
|
(AppVeyor 1st-time failure was in AppVeyor's init itself, not the JMRI part - restarted) |
|
Similar AppVeyor fail on 2nd try. The AppVeyor build queues are now closed, so perhaps they're working on something. Will leave this alone for a bit & then restart the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Booleanwithbooleanwithin the Shutdown manager API, which breaks binary compatibility, but does not require any further code changes.