Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations java21 #13223

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

danielb987
Copy link
Contributor

@bobjacobsen
This PR fixes some of the deprecations that will hit us with Java 21. In some cases, I have chosen to suppress the warnings since the replacements isn't available until we move to Java 21. Once we have done the move to Java21, it's easy to fix these.

I have changed the public constructor of jmri.util.MultipartMessage so that it throws an additional exception. I thought it would be better if the caller handled the original URISyntaxException, than to have this class throw an IOException with the URISyntaxException as cause. But it might affect people that are using JMRI as a library.

@danielb987 danielb987 added the New PR Newly created PR that is less than 1 day old label Jun 26, 2024
@danielb987 danielb987 self-assigned this Jun 26, 2024
Copy link

mergeable bot commented Jun 26, 2024

Thanks for the PR. Please consider adding a release note in the help/en/releasenotes/current-draft-note.shtml file.

Copy link
Member

@bobjacobsen bobjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these!

@bobjacobsen
Copy link
Member

Merging early for 5.9.1

@bobjacobsen bobjacobsen merged commit 4483786 into JMRI:master Jun 26, 2024
13 of 14 checks passed
@danielb987 danielb987 deleted the FixDeprecationsJava21 branch June 26, 2024 19:15
@danielb987 danielb987 added this to the 5.9.1 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New PR Newly created PR that is less than 1 day old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants