Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable frame server #1334

Merged
merged 5 commits into from May 21, 2016
Merged

Disable frame server #1334

merged 5 commits into from May 21, 2016

Conversation

rhwood
Copy link
Contributor

@rhwood rhwood commented May 21, 2016

This is from a user’s request in private email.

@rhwood rhwood added this to the 4.3.7 milestone May 21, 2016
@rhwood rhwood merged commit 96f6015 into JMRI:master May 21, 2016
rhwood added a commit to JMRI/website that referenced this pull request May 21, 2016
@rhwood rhwood deleted the disable-frame-server branch May 21, 2016 13:21
@bobjacobsen
Copy link
Member

Curious as to why it's useful to disable it. Does it interfere with something?

Thanks.

@rhwood
Copy link
Contributor Author

rhwood commented May 21, 2016

Certain features (notably the linking labels) of the Panels don't, and can't, function correctly when displayed using the frame servlet since the frame servlet can't open a new or different window.

WiThrottle automatically opens the frame servlet when it connects to the web server and does not allow users to override this; nor does it allow a user to bookmark other pages (it offers a UI for this, but does not retain added bookmarks).

The inability to bring the correct page up first in WiThrottle led a club to request that the frame server be easy to disable. I added the ability to redirect to the panel servlet, since it serves their needs better than what was requested, but also met the original requirement, by allowing the redirect to be disabled as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants