Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include GUI tests in CI testing #213

Merged
merged 13 commits into from
Nov 21, 2015
Merged

Include GUI tests in CI testing #213

merged 13 commits into from
Nov 21, 2015

Conversation

rhwood
Copy link
Contributor

@rhwood rhwood commented Nov 18, 2015

Travis-CI supports GUI testing, so leverage it during CI testing.

@rhwood rhwood mentioned this pull request Nov 18, 2015
5 tasks
@bobjacobsen
Copy link
Member

#215 may fix the last two.

@rhwood
Copy link
Contributor Author

rhwood commented Nov 21, 2015

Running AllTest runs into a timing issue on Travis-CI:

  • Travis-CI kills processes that run from 10 minutes or more without any output
  • AllTest provides no output until all tests are run, at which point it prints a summary and dumps its output
  • AllTest can take more than 10 minutes to run

Is there any way to change AllTest's behavior to print its summary at the end of the log, and to provide running output, to prevent Travis-CI from killing it?

I am currently using a special travis-wait command to extend the Travis-CI timeout to 20 minutes, but would prefer not to if possible.

rhwood added a commit that referenced this pull request Nov 21, 2015
Include GUI tests in CI testing
@rhwood rhwood merged commit f38aaff into JMRI:master Nov 21, 2015
@bobjacobsen
Copy link
Member

The junit.textui.TestRunner always caches its stdout away for replay (and sometimes processing) at the end. If we want output to the real (not cached) stdout, we could create our own TestRunner implementation based on copying junit.textui.TestRunner. Unfortunately, it's not just a matter of subclassing, because junit.textui.TestRunner uses a bunch of statics.

@rhwood
Copy link
Contributor Author

rhwood commented Nov 21, 2015

Would this be doable if upgraded to JUnit 4?

@bobjacobsen
Copy link
Member

Would this be doable if upgraded to JUnit 4?

I don't know. I've never actually done a JUnit 3 to 4 migration, but I've heard that they involve some rework. Not sure how extensive it would actually be on our code, which has a pretty regular structure.

http://stackoverflow.com/questions/264680/best-way-to-automagically-migrate-tests-from-junit-3-to-junit-4

When (not if) we migrate, we should probably also rethink how we use TestSuite to organize a test hierarchy. Might be right, might not be.

bobjacobsen pushed a commit to bobjacobsen/JMRI that referenced this pull request Oct 5, 2017
Update DuplexGroupTabbed_fr.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants