Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuse to run startup actions if earlier errors #2799

Merged
merged 10 commits into from Jan 3, 2017
Merged

Refuse to run startup actions if earlier errors #2799

merged 10 commits into from Jan 3, 2017

Commits on Dec 31, 2016

  1. Copy the full SHA
    fc0f9ff View commit details
    Browse the repository at this point in the history
  2. Remove excess quoting

    rhwood committed Dec 31, 2016
    Copy the full SHA
    47f510f View commit details
    Browse the repository at this point in the history
  3. Minor cleanup

    Spelling, Overrides, and unneeded method call
    rhwood committed Dec 31, 2016
    Copy the full SHA
    c61be81 View commit details
    Browse the repository at this point in the history
  4. API for managers initializing with errors

    Add API for PreferencesManagers to initialize with errors, so they are
    in a state that can be checked so follow on managers can refuse to
    initialize as well.
    rhwood committed Dec 31, 2016
    Copy the full SHA
    0782958 View commit details
    Browse the repository at this point in the history
  5. Use new PreferencesManager API to display errors

    Also take steps to ensure a manager is not initialized more than once
    if initialized with errors.
    Errors are displayed in the order they occur.
    rhwood committed Dec 31, 2016
    Copy the full SHA
    a6e8890 View commit details
    Browse the repository at this point in the history
  6. Use new API to display errors with connections.

    The real error is *always* shown in a separate dialog because the
    XmlAdapters use a different mechanism for displaying those errors and
    will not propagate them up the call stack.
    Also provide constructor to create an InitializationException purely
    from a cause.
    rhwood committed Dec 31, 2016
    Copy the full SHA
    8753261 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2017

  1. Allow the StartupManager to not perform actions when loading preferences

    The StartupManager now does a two step process for loading its
    preferences. It loads all preferences into memory (creating the list of
    actions available in the preferences window) and then, if there were
    not errors blocking it, performs those actions.
    
    To make this work, the triggers for startup actions were moved from the
    XmlAdapters that load the actions to the StartupModels themselves. Some
    actions still need to throw nicer error messages, but this generally
    works now.
    rhwood committed Jan 1, 2017
    Copy the full SHA
    6b00233 View commit details
    Browse the repository at this point in the history
  2. JavaDoc error

    rhwood committed Jan 1, 2017
    Copy the full SHA
    d212c11 View commit details
    Browse the repository at this point in the history
  3. Use streams

    rhwood committed Jan 1, 2017
    Copy the full SHA
    2f81253 View commit details
    Browse the repository at this point in the history
  4. Only attempt to perform valid actions

    If a startup action is not valid, do not perform it.
    rhwood committed Jan 1, 2017
    Copy the full SHA
    ddd45ba View commit details
    Browse the repository at this point in the history