Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FindBugs Warnings #2939

Merged
merged 15 commits into from Jan 28, 2017
Merged

Fix FindBugs Warnings #2939

merged 15 commits into from Jan 28, 2017

Conversation

rhwood
Copy link
Contributor

@rhwood rhwood commented Jan 26, 2017

No description provided.

@rhwood
Merge remote-tracking branch 'JMRI/master' into javadoc-warnings
b156481
@rhwood
Silence a FIndBugs error
5d85803
@rhwood
Silence FindBugs errors
c7ae14a
@rhwood
Merge remote-tracking branch 'JMRI/master' into javadoc-warnings
06e534f
@rhwood
Fix FindBugs warnings
2840c5f 
I think this fixes all normal priority correctness warnings
@rhwood
Ensure logging is configured before class instance.
4939a7d
@rhwood
Merge remote-tracking branch 'JMRI/master' into javadoc-warnings
b245ea8
@rhwood
BeforeClass setup methods must be static
4454fd4
@rhwood
Merge remote-tracking branch 'JMRI/master' into javadoc-warnings
9c5d7b9
@rhwood
Setup logging when building test parameter set
a4984d1 
Test parameters are setup before ```@BeforeClass``` annotated methods
are called, so initialize logging early.

This is most likely only needed in this test because it is run outside
of the AllTest/HeadlessTest suites on CI servers.
@rhwood
Merge remote-tracking branch 'JMRI/master' into javadoc-warnings
a50e609
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 29.538% when pulling 9c5d7b9 on rhwood:javadoc-warnings into 520f0ef on JMRI:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 29.538% when pulling 9c5d7b9 on rhwood:javadoc-warnings into 520f0ef on JMRI:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 29.631% when pulling a50e609 on rhwood:javadoc-warnings into 8b36b06 on JMRI:master.

@coveralls
Copy link

coveralls commented Jan 27, 2017 •
edited

Coverage Status

Coverage decreased (-0.004%) to 29.638% when pulling a50e609 on rhwood:javadoc-warnings into 8b36b06 on JMRI:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 29.541% when pulling a50e609 on rhwood:javadoc-warnings into 8b36b06 on JMRI:master.

@coveralls
Copy link

coveralls commented Jan 27, 2017 •
edited

Coverage Status

Coverage increased (+0.0009%) to 29.643% when pulling a50e609 on rhwood:javadoc-warnings into 8b36b06 on JMRI:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 29.564% when pulling 978174a on rhwood:javadoc-warnings into 130c10b on JMRI:master.

@coveralls
Copy link

coveralls commented Jan 28, 2017 •
edited

Coverage Status

Coverage increased (+0.02%) to 29.673% when pulling 978174a on rhwood:javadoc-warnings into 130c10b on JMRI:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 29.554% when pulling d230fc8 on rhwood:javadoc-warnings into 130c10b on JMRI:master.

@rhwood
Set explicit log4j config filename
ccade8c 
The default directory under maven is not the base dir.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 29.56% when pulling ccade8c on rhwood:javadoc-warnings into 130c10b on JMRI:master.

@coveralls
Copy link

coveralls commented Jan 28, 2017 •
edited

Coverage Status

Coverage increased (+0.01%) to 29.666% when pulling ccade8c on rhwood:javadoc-warnings into 130c10b on JMRI:master.

@rhwood
Avoid a circular dependency issue.
3b18e5d 
FileUtil logs the directory creation, so use Files to create the
directory and parent directories (if needed).
@coveralls
Copy link

coveralls commented Jan 28, 2017 •
edited

Coverage Status

Coverage increased (+0.01%) to 29.667% when pulling 3b18e5d on rhwood:javadoc-warnings into 130c10b on JMRI:master.

@rhwood rhwood merged commit 74a5056 into JMRI:master Jan 28, 2017
@rhwood rhwood deleted the javadoc-warnings branch January 28, 2017 17:00
@bobjacobsen bobjacobsen mentioned this pull request Feb 1, 2017
Closed
@bobjacobsen bobjacobsen mentioned this pull request Feb 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhwood @coveralls