set hasBackground to false if the background color alpha value=0 #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
partially addresses #4519 includes tests to make sure property is set. |
|
This PR is from pabender/master which includes changes from after the release-4.9.7 branch. That means it can't be cleanly merged into the release-4.9.7 branch. Is it important enough to spend time fixing that? |
|
Sent from my iPad
On Dec 7, 2017, at 1:41 AM, Bob Jacobsen ***@***.***> wrote:
This PR is from pabender/master which includes changes from after the release-4.9.7 branch. That means it can't be cleanly merged into the release-4.9.7 branch.
Is it important enough to spend time fixing that?
This one definitely. I can fix that locally in the morning, if it can wait a few hours. Past my bedtime here now.
Paul
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.