Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AbstractNamedBean.getFullyFormattedDisplayName() final #6462

Merged
merged 1 commit into from Jan 19, 2019

Conversation

danielb987
Copy link
Contributor

I also tested to make AbstractNamedBean.toString() final, but that method has a lot of different implementations and I'm afraid to break things if I change that.

The classes with different toString() implementations are:
jmri.jmrit.logix.Portal
jmri.implementation.AbstractAudio
jmri.implementation.AbstractIdTag
jmri.implementation.AbstractStringIO - This is created by me and new so changing it will probably not break anything.
jmri.implementation.DefaultRailCom
jmri.implementation.DefaultSignalSystem
jmri.jmrit.audio.AbstractAudioListener
jmri.jmrit.audio.AbstractAudioSource
jmri.jmrit.audio.JavaSoundAudioBuffer
jmri.jmrit.audio.JoalAudioBuffer
jmri.jmrit.audio.NullAudioBuffer

@danielb987
Copy link
Contributor Author

Closed and reopened PR due to AppVeyor:

Build started
git clone -q --depth=50 https://github.com/JMRI/JMRI.git C:\projects\jmri
fatal: early EOF
fatal: The remote end hung up unexpectedly
fatal: index-pack failed
error: RPC failed; curl 56 OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 10054
Command exited with code 128

@danielb987 danielb987 closed this Jan 19, 2019
@danielb987 danielb987 reopened this Jan 19, 2019
@danielb987
Copy link
Contributor Author

This PR is ready to be merged. The discussion of toString() is moved to PR #6463.

@bobjacobsen bobjacobsen added this to the 4.15.3 milestone Jan 19, 2019
@bobjacobsen bobjacobsen merged commit abe8c7c into JMRI:master Jan 19, 2019
@danielb987 danielb987 deleted the make_methods_final branch January 19, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants