Localize Splash and Connection Prefs #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cale Create Disable Connection checkbox name from .properties instead of hard coded (jmrix), add keys Create Use Non-Standard Msg checkbox name from .properties instead of hard coded (GuiLaf), add keys Cleanup keys in .properties files to pass i18n-consistency-check Some German .props in top menus
…h screen. May explain why some .properties aren't read to build Preferences.
In xml/config/parts/jmri/jmrit/roster/swing/RosterFrame*.xml (was expecting .properties to have the same effect) Will add a pointer to Translation Help if this is the right method for this part.
Add German menu translations for DP3
Localize German
| @@ -40,7 +40,7 @@ | |||
| */ | |||
| public class ConnectionsPreferencesPanel extends JTabbedPane implements ManagingPreferencesPanel { | |||
|
|
|||
| private static final ResourceBundle rb = ResourceBundle.getBundle("apps.AppsConfigBundle"); // NOI18N | |||
| private static final ResourceBundle rb = ResourceBundle.getBundle("apps.AppsConfigBundle"); // NOI18N for some items | |||
There was a problem hiding this comment.
The //NOI18N comment should remain as-is this is used by several IDE's to flag a specific text string as not being for internationalisation.
Changing this comment, might break that functionality.
There was a problem hiding this comment.
Good point, hadn't thought of that. See #782 and silverailscolo#15
|
I've added a few comments about minor things, but thanks - this is a great step forward for JMRI and its use in other languages. Thanks! |
| public String getTitle() { | ||
| return rb.getString("TitlePreferences"); | ||
| } | ||
| public String getTitle() { return Bundle.getMessage("TitlePreferences"); } |
There was a problem hiding this comment.
This needs to be multi line. We want to avoid making unnecessarily compact code.
|
Thank you for your work on this. You might find the "i18n-consistency-check" ant target helpful. The "// NOI18N" comments indicate that the string literal on the line containing the comment should not be translated. |
It looks like an MacOS X -specific value crept in for the OUTPUT_DIRECTORY parameter. This puts it back the way it was. Note: I'm not an Idea user, so can't directly test this.
The "// NOI18N" comment means that a string on that line shouldn't be translated, e.g. its a translation key or something else that's _not_ presented to the user. Some IDEs need it just like that, which means that it shouldn't mix with _other_ comment text about that line. This moves that magic comment to the end for one line in the file.
…obj-1 Remove OUTPUT_DIRECTORY value
…obj-2 Clean // NOI18N comment
Merge PR from master
Ellipsis back after Context and System Console (de), different ideas on Fensterhilfe. Prefer to adhere to Apple User Interface Guide (ellipses belong with menus that provide a dialog for follow up action).
bobjacobsen
added a commit
that referenced
this pull request
Feb 11, 2016
Localize Splash and Connection Prefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localize button names
Add German .properties
Fix spelling on Splash and localize (picks up OS Locale if available)
Partial localization of DP3 menubar via xml