Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrixmast reset prev aspect setting #7945

Merged
merged 1 commit into from Jan 15, 2020

Conversation

silverailscolo
Copy link
Contributor

store/load Reset previous aspect for mast, schema

@silverailscolo silverailscolo self-assigned this Jan 14, 2020
@bobjacobsen
Copy link
Member

Thanks for this!

If you add the new content to java/test/jmri/implementation/configurexml/load/TenMastOutputs.xml, the load/store tests will make sure it doesn't get broken.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #7945 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7945      +/-   ##
============================================
+ Coverage     47.43%   47.48%   +0.04%     
- Complexity    51318    51362      +44     
============================================
  Files          4162     4162              
  Lines        403281   403286       +5     
  Branches      60198    60201       +3     
============================================
+ Hits         191289   191484     +195     
+ Misses       192482   192275     -207     
- Partials      19510    19527      +17
Impacted Files Coverage Δ Complexity Δ
java/src/jmri/implementation/MatrixSignalMast.java 54.92% <ø> (ø) 39 <0> (ø) ⬇️
...plementation/configurexml/MatrixSignalMastXml.java 77.57% <0%> (-3.81%) 12 <0> (ø)
...54/xbee/swing/nodeconfig/AssignmentTableModel.java 20.4% <0%> (-14.29%) 5% <0%> (-5%)
java/src/jmri/server/json/JsonWebSocket.java 46.51% <0%> (-6.98%) 6% <0%> (-1%)
...src/jmri/jmrix/dccpp/dccppovertcp/ServerFrame.java 71.59% <0%> (-6.82%) 9% <0%> (-1%)
java/src/jmri/jmris/JmriConnection.java 58.97% <0%> (-2.57%) 7% <0%> (-1%)
...ava/src/jmri/jmrit/dispatcher/AutoTrainsFrame.java 50.77% <0%> (-1.04%) 20% <0%> (-1%)
...mri/jmrit/beantable/AddNewHardwareDevicePanel.java 84.31% <0%> (-0.99%) 8% <0%> (-1%)
java/src/jmri/jmrit/ctc/editor/gui/FrmIL.java 80.83% <0%> (-0.6%) 13% <0%> (ø)
java/src/jmri/jmrit/dispatcher/ActiveTrain.java 37.7% <0%> (-0.37%) 87% <0%> (-1%)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e8e1e...cd434ab. Read the comment docs.

@bobjacobsen bobjacobsen added this to the 4.19.3 milestone Jan 15, 2020
@bobjacobsen bobjacobsen merged commit f87dc2b into JMRI:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants