Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JmriException supports messages of several lines #9740

Merged
merged 1 commit into from
May 3, 2021

Conversation

danielb987
Copy link
Contributor

No description provided.

@danielb987 danielb987 added this to the 4.23.5 milestone May 1, 2021
@danielb987 danielb987 self-assigned this May 1, 2021
@mergeable mergeable bot added the New PR Newly created PR that is less than 1 day old label May 1, 2021
@mergeable
Copy link

mergeable bot commented May 1, 2021

Thanks for the PR. Please consider adding a release note in the help/en/releasenotes/current-draft-note.shtml file.

@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #9740 (e9ddcc5) into master (50e8b2b) will decrease coverage by 0.1%.
The diff coverage is 23.1%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #9740     +/-   ##
===========================================
- Coverage      51.7%    51.7%   -0.0%     
+ Complexity    63665    63631     -34     
===========================================
  Files          5098     5097      -1     
  Lines        443325   443332      +7     
  Branches      64044    64051      +7     
===========================================
- Hits         229032   228928    -104     
- Misses       191708   191844    +136     
+ Partials      22585    22560     -25     
Impacted Files Coverage Δ Complexity Δ
...rit/logixng/implementation/AbstractMaleSocket.java 55.9% <ø> (ø) 65.0 <0.0> (ø)
.../implementation/DefaultMaleAnalogActionSocket.java 94.0% <0.0%> (ø) 32.0 <0.0> (ø)
...lementation/DefaultMaleAnalogExpressionSocket.java 90.3% <0.0%> (ø) 32.0 <0.0> (ø)
...implementation/DefaultMaleDigitalActionSocket.java 93.2% <0.0%> (ø) 27.0 <0.0> (ø)
...ntation/DefaultMaleDigitalBooleanActionSocket.java 93.3% <0.0%> (ø) 28.0 <0.0> (ø)
...ementation/DefaultMaleDigitalExpressionSocket.java 84.3% <0.0%> (+1.1%) 28.0 <0.0> (ø)
.../implementation/DefaultMaleStringActionSocket.java 93.3% <0.0%> (ø) 28.0 <0.0> (ø)
...lementation/DefaultMaleStringExpressionSocket.java 89.1% <0.0%> (ø) 28.0 <0.0> (ø)
java/src/jmri/JmriException.java 48.0% <50.0%> (-2.0%) 6.0 <4.0> (+4.0) ⬇️
...rations/trains/tools/ExportTrainLineupsAction.java 50.0% <0.0%> (-50.0%) 1.0% <0.0%> (-1.0%)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e8b2b...e9ddcc5. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 56.787% when pulling e9ddcc5 on danielb987:JmriException_multiline into 50e8b2b on JMRI:master.

@danielb987
Copy link
Contributor Author

@bobjacobsen Do you want all the exceptions that inherits JmriException to also have the constructors that takes the list or can that wait until somebody wants it?

@danielb987 danielb987 removed the New PR Newly created PR that is less than 1 day old label May 2, 2021
@danielb987 danielb987 merged commit 6dc7851 into JMRI:master May 3, 2021
@danielb987 danielb987 deleted the JmriException_multiline branch May 3, 2021 19:32
Copy link
Member

@bobjacobsen bobjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to wait on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants