-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute/evaluate to TreeEditor #9836
Add execute/evaluate to TreeEditor #9836
Conversation
Thanks for the PR. Please consider adding a release note in the help/en/releasenotes/current-draft-note.shtml file. |
Thanks for the PR. It includes changes to properties files, so the 'Needs L10N' label has been added" |
It doesn't currently work to execute/evaluate an action/expression in a Module. But I'm working on that. |
Codecov Report
@@ Coverage Diff @@
## master #9836 +/- ##
===========================================
- Coverage 51.8% 51.8% -0.0%
- Complexity 64065 64116 +51
===========================================
Files 5098 5101 +3
Lines 445013 445246 +233
Branches 64285 64335 +50
===========================================
+ Hits 230169 230281 +112
- Misses 192120 192201 +81
- Partials 22724 22764 +40
Continue to review full report at Codecov.
|
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The evaluate/execute menu items work fine.
The Table: for each
works. The new dialog structure and descriptions are much better.
@dsand47
This PR adds the popup menu item "Execute" or "Evaluate" when you right click (command click) on an action or expression in the ConditionalNG editor.
If you select
Execute
on an action, that action is executed and a message box is shown when the action is completed.If you select
Evaluate
on an expression, that expression is evaluated and the result is shown in a message box when the expression is completed.This allows you to execute/evaluate only a part of the tree, which might be useful for debugging.
One thing is still missing: If the tree has local variables, these variables are initialized. But the user has no way to change these variables. When execute/evaluate is selected and there is local variables, I will show a table to the user there he might give other values to the variables if he wants to.