Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative car blocking numbers #9871

Merged
merged 4 commits into from
Jun 7, 2021

Conversation

DanielBoudreau
Copy link
Contributor

No description provided.

@DanielBoudreau DanielBoudreau added the Add to Next Test Release Needed before the next test release label Jun 6, 2021
@DanielBoudreau DanielBoudreau added this to the 4.23.7 milestone Jun 6, 2021
@DanielBoudreau DanielBoudreau self-assigned this Jun 6, 2021
@mergeable mergeable bot added the New PR Newly created PR that is less than 1 day old label Jun 6, 2021
@mergeable
Copy link

mergeable bot commented Jun 6, 2021

Thanks for the PR. Please consider adding a release note in the help/en/releasenotes/current-draft-note.shtml file.

danielb987
danielb987 previously approved these changes Jun 6, 2021
@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #9871 (f5404bd) into master (8c5201e) will increase coverage by 0.1%.
The diff coverage is 79.0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #9871     +/-   ##
===========================================
+ Coverage      51.8%    51.8%   +0.1%     
- Complexity    64095    64115     +20     
===========================================
  Files          5099     5099             
  Lines        445244   445238      -6     
  Branches      64342    64336      -6     
===========================================
+ Hits         230199   230264     +65     
+ Misses       192302   192230     -72     
- Partials      22743    22744      +1     
Impacted Files Coverage Δ
...ri/jmrit/operations/rollingstock/RollingStock.java 81.0% <ø> (ø)
...operations/rollingstock/RollingStockEditFrame.java 94.4% <20.0%> (-0.2%) ⬇️
...src/jmri/jmrit/operations/trains/TrainBuilder.java 94.2% <100.0%> (+0.5%) ⬆️
.../jmrit/symbolicprog/tabbedframe/WatchingLabel.java 38.5% <0.0%> (-15.3%) ⬇️
...54/xbee/swing/nodeconfig/AssignmentTableModel.java 20.5% <0.0%> (-14.2%) ⬇️
...ri/jmrit/operations/routes/tools/ExportRoutes.java 67.9% <0.0%> (-8.3%) ⬇️
java/src/jmri/jmris/JmriConnection.java 59.0% <0.0%> (-7.6%) ⬇️
java/src/jmri/server/json/JsonWebSocket.java 46.7% <0.0%> (-6.6%) ⬇️
java/src/jmri/jmrit/entryexit/PointDetails.java 36.6% <0.0%> (-5.7%) ⬇️
...ix/can/cbus/swing/nodeconfig/CbusNodeInfoPane.java 79.1% <0.0%> (-4.1%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c5201e...f5404bd. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 56.884% when pulling f5404bd on DanielBoudreau:master into 8c5201e on JMRI:master.

@DanielBoudreau DanielBoudreau removed the New PR Newly created PR that is less than 1 day old label Jun 7, 2021
@mergeable mergeable bot added the New PR Newly created PR that is less than 1 day old label Jun 7, 2021
@DanielBoudreau DanielBoudreau removed the New PR Newly created PR that is less than 1 day old label Jun 7, 2021
@DanielBoudreau DanielBoudreau merged commit 205627b into JMRI:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add to Next Test Release Needed before the next test release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants