Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce tractive effort to HP conversion by 40% #9887

Merged
merged 1 commit into from Jun 14, 2021

Conversation

DanielBoudreau
Copy link
Contributor

No description provided.

@DanielBoudreau DanielBoudreau added the Add to Next Test Release Needed before the next test release label Jun 13, 2021
@DanielBoudreau DanielBoudreau added this to the 4.23.7 milestone Jun 13, 2021
@DanielBoudreau DanielBoudreau self-assigned this Jun 13, 2021
@mergeable mergeable bot added New PR Newly created PR that is less than 1 day old Needs L10N Needs localization labels Jun 13, 2021
@mergeable
Copy link

mergeable bot commented Jun 13, 2021

Thanks for the PR. It includes changes to properties files, so the 'Needs L10N' label has been added"

@mergeable
Copy link

mergeable bot commented Jun 13, 2021

This PR includes files in the help hierarchy so the 'Documentation' label has been added. Other labels may also be applied."

@DanielBoudreau
Copy link
Contributor Author

restart travis after:

ERROR] Failures:
[ERROR] RpsSensorManagerTest>AbstractSensorMgrTestBase.testProvideFailure:116 Level mismatch when looking for ERROR message: "Invalid system name for Sensor: System name must start with "RS"." found "sendLocoNetMessage: IOException: java.io.IOException: Read end dead"

@DanielBoudreau
Copy link
Contributor Author

Restart Windows CI Tests after:

Error: Errors:
Error: LayoutEditorToolsTest.tearDown:655->Object.wait:502->Object.wait:-2 � TestTimedOut

@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #9887 (f0c825e) into master (058f564) will decrease coverage by 0.1%.
The diff coverage is 66.7%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #9887     +/-   ##
===========================================
- Coverage      51.7%    51.7%   -0.0%     
- Complexity    64214    64225     +11     
===========================================
  Files          5112     5112             
  Lines        446323   446323             
  Branches      64479    64479             
===========================================
- Hits         230742   230712     -30     
- Misses       192797   192833     +36     
+ Partials      22784    22778      -6     
Impacted Files Coverage Δ
...erations/rollingstock/engines/EngineEditFrame.java 88.7% <66.7%> (ø)
.../jmrix/roco/z21/simulator/Z21SimulatorAdapter.java 36.4% <0.0%> (-15.9%) ⬇️
.../src/jmri/jmrix/roco/z21/Z21TrafficController.java 29.1% <0.0%> (-10.0%) ⬇️
...va/src/jmri/jmrix/roco/z21/Z21XPressNetTunnel.java 70.9% <0.0%> (-7.5%) ⬇️
...jmri/jmrit/pragotronclock/PragotronClockFrame.java 92.5% <0.0%> (-7.5%) ⬇️
...perations/locations/schedules/ExportSchedules.java 71.8% <0.0%> (-6.4%) ⬇️
java/src/jmri/jmrix/roco/z21/Z21HeartBeat.java 65.3% <0.0%> (-4.3%) ⬇️
...ri/jmrix/roco/z21/Z21XNetStreamPortController.java 95.9% <0.0%> (-4.1%) ⬇️
...ix/roco/z21/simulator/Z21XNetSimulatorAdapter.java 27.4% <0.0%> (-3.2%) ⬇️
java/src/jmri/util/ThreadingUtil.java 57.3% <0.0%> (-2.7%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 058f564...f0c825e. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 56.854% when pulling f0c825e on DanielBoudreau:master into 058f564 on JMRI:master.

@DanielBoudreau
Copy link
Contributor Author

Restart Windows CI after:

Error: Errors:
Error: LayoutEditorToolsTest.testSetSignalsAtTurnoutWithCancel:396 � TestTimedOut tes...
[INFO]

@DanielBoudreau DanielBoudreau removed the New PR Newly created PR that is less than 1 day old label Jun 14, 2021
@DanielBoudreau DanielBoudreau merged commit d8a3f89 into JMRI:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add to Next Test Release Needed before the next test release Documentation Needs L10N Needs localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants