Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httplib2 0.12.0 release breaks cert handling #30

Closed
JNRowe opened this issue Nov 21, 2018 · 2 comments
Closed

httplib2 0.12.0 release breaks cert handling #30

JNRowe opened this issue Nov 21, 2018 · 2 comments
Assignees
Labels

Comments

@JNRowe
Copy link
Owner

JNRowe commented Nov 21, 2018

Upstream has massively changed the way they handle certificates, and we’ll need to adapt to make that work.

It isn’t clear if we should be forcing <0.12.0, or attempt to produce a workaround that works with both. It will depend on the complexity.

[Note to self: Ping Matt for his 2c on the chances of getting 0.12.0 promoted up the queue for packaging. Without that forcing <0.12.0 is probably the only option.]

@JNRowe JNRowe self-assigned this Nov 21, 2018
@JNRowe JNRowe added the bug label Nov 21, 2018
JNRowe added a commit that referenced this issue Nov 21, 2018
JNRowe added a commit that referenced this issue Nov 24, 2018
Refs #30, but can’t close as this is *not* an acceptable long term fix.

* b/httplib2_certs:
  Mask httplib2 v0.12 as it changes cert handling
@JNRowe
Copy link
Owner Author

JNRowe commented Nov 24, 2018

I've pushed this with forced <0.12, as it is breaking deployments. It really isn't clear what the correct way to move forward is, 0.12 isn't going to be packaged globally anytime soon and increased complexity to cover both is huge.

Matt has at least pushed in a really cool QA check to make sure nobody is accidentally receiving the incorrect certificates, but obviously that isn't going to work for people who aren't using our infrastructure.

Weekend to spin...

@JNRowe
Copy link
Owner Author

JNRowe commented Aug 4, 2019

After [once again] talking this over with co-workers the decision to stop supporting httplib2 in other projects has been made. So jnrbase.httplib2_certs will be deprecated in 1.2, and gone in 1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant