Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --server-discovery help and a #72

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Fix --server-discovery help and a #72

merged 1 commit into from
Aug 15, 2022

Conversation

JOJ0
Copy link
Owner

@JOJ0 JOJ0 commented Aug 15, 2022

wrong variable name in the config subcommand.

@JOJ0
Fix --server-discovery help and a
3466009 
wrong variable name in the config subcommand.
@JOJ0 JOJ0 requested a review from Ascurius August 15, 2022 08:50
@JOJ0
Copy link
Owner Author

JOJ0 commented Aug 15, 2022

Hi @Ascurius, found a wrong variable name while trying to describe what the --server-discovery optiona is all about. Thanks for a review in advance!

Ascurius
Ascurius approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@Ascurius Ascurius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JOJ0, thank you for the rephrasing of the help text. It is now much clearer and understandable what the option does. Thus I would say we are ready to merge this change

@JOJ0 JOJ0 merged commit 5b31d21 into master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ascurius Ascurius Ascurius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JOJ0 @Ascurius