Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Integer Vectors #71

Merged
merged 3 commits into from Jan 5, 2016
Merged

Adding Integer Vectors #71

merged 3 commits into from Jan 5, 2016

Conversation

huhlig
Copy link
Contributor

@huhlig huhlig commented Dec 18, 2015

Here is a basic set. Still looking at how to template the generation easily.

@httpdigest
Copy link
Member

Can you give a use-case that you have where those methods are currently useful for you?
Otherwise, I'd now prefer to not include methods without a use-case or where we are not quite sure of the semantics and signature, until someone asks for them.

@huhlig
Copy link
Contributor Author

huhlig commented Dec 21, 2015

Should I clear out most of the math functions then? My specific use case for the class is for a common container class for Tile Coordinates, Vertex Indices, and Uniform Values. I don't need the math functions.

@httpdigest
Copy link
Member

I guess so, yes. I reckon we can leave methods where the result and semantics are 100% clear, like add/sub/mul.

@huhlig
Copy link
Contributor Author

huhlig commented Dec 21, 2015

Sounds good. Let me update.

Hans W. Uhlig - huhlig@gmail.com
PGP Key: F509CF9D892BDBE8
PGP Fingerprint: 74AF EDD7 7427 3288 45AB 6FCB F509 CF9D 892B DBE8

On Mon, Dec 21, 2015 at 6:35 AM, Kai Burjack notifications@github.com
wrote:

I guess so, yes. I reckon we can leave methods where the result and
semantics are 100% clear, like add/sub/mul.


Reply to this email directly or view it on GitHub
#71 (comment).

@httpdigest
Copy link
Member

Yes, I agree with you. It's about time for your template system. ;)

httpdigest added a commit that referenced this pull request Jan 5, 2016
@httpdigest httpdigest merged commit 8628315 into JOML-CI:master Jan 5, 2016
@httpdigest
Copy link
Member

I decided to integrate those integral component vectors in the next JOML release 1.6.8 and merged your changes. I am going to do some reformatting, though.
Would you like to be named as @author on your classes?

@httpdigest httpdigest added this to the 1.6.8 release milestone Jan 5, 2016
@huhlig
Copy link
Contributor Author

huhlig commented Jan 5, 2016

Sure. Take a look at the code generation when you get a chance. Let me know what you think.

Hans Uhlig via Mobile | Big Data Engineer/Architect

On Jan 5, 2016, at 2:07 AM, Kai Burjack notifications@github.com wrote:

I decided to integrate those integral component vectors in the next JOML release 1.6.8 and merged your changes. I am going to do some reformatting, though.
Would you like to be named as @author on your classes?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants