Skip to content

Fix an issue where a custom source would have "&" for the first query parameter instead of "?" #200

Fix an issue where a custom source would have "&" for the first query parameter instead of "?"

Fix an issue where a custom source would have "&" for the first query parameter instead of "?" #200

GitHub Actions / JUnit Test Report failed Jan 16, 2024 in 0s

222 tests run, 217 passed, 2 skipped, 3 failed.

Annotations

Check failure on line 197 in josm/plugins/MapWithAI/src/test/unit/org/openstreetmap/josm/plugins/mapwithai/actions/AddMapWithAILayerActionTest.java

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

AddMapWithAILayerActionTest.testNonRegression22683()

Unexpected exception thrown: java.lang.RuntimeException: java.lang.RuntimeException: org.openstreetmap.josm.io.OsmApiException: ResponseCode=404
Raw output
org.opentest4j.AssertionFailedError: Unexpected exception thrown: java.lang.RuntimeException: java.lang.RuntimeException: org.openstreetmap.josm.io.OsmApiException: ResponseCode=404
	at org.openstreetmap.josm.plugins.mapwithai.actions.AddMapWithAILayerActionTest.testNonRegression22683(AddMapWithAILayerActionTest.java:197)
	Suppressed: org.opentest4j.AssertionFailedError: /query?geometryType=esriGeometryEnvelope&geometry={bbox}&inSR=4326&f=geojson&outfields=*&result_type=road_building_vector_xml?resultOffset=0

/query?geometryType=esriGeometryEnvelope&geometry={bbox}&inSR=4326&f=geojson&outfields=*&result_type=road_building_vector_xml?resultOffset=0 ==> expected: <true> but was: <false>
		at org.openstreetmap.josm.testutils.annotations.BasicWiremock$WireMockExtension.afterEach(BasicWiremock.java:143)
		at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
		at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
		at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
		at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
		at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
		at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: org.openstreetmap.josm.io.OsmApiException: ResponseCode=404
	at org.openstreetmap.josm.plugins.mapwithai.actions.AddMapWithAILayerAction.actionPerformed(AddMapWithAILayerAction.java:116)
	at org.openstreetmap.josm.plugins.mapwithai.actions.AddMapWithAILayerActionTest.lambda$testNonRegression22683$2(AddMapWithAILayerActionTest.java:197)
	... 1 more
Caused by: java.lang.RuntimeException: org.openstreetmap.josm.io.OsmApiException: ResponseCode=404
Caused by: org.openstreetmap.josm.io.OsmApiException: ResponseCode=404
	at org.openstreetmap.josm.io.OsmServerReader.getInputStreamRaw(OsmServerReader.java:220)
	at org.openstreetmap.josm.io.OsmServerReader.getInputStreamRaw(OsmServerReader.java:142)
	at org.openstreetmap.josm.io.OsmServerReader.getInputStreamRaw(OsmServerReader.java:126)
	at org.openstreetmap.josm.io.OsmServerReader.getInputStream(OsmServerReader.java:90)
	at org.openstreetmap.josm.io.OsmServerReader.getInputStream(OsmServerReader.java:73)
	at org.openstreetmap.josm.io.BoundingBoxDownloader.parseOsm(BoundingBoxDownloader.java:211)
	at org.openstreetmap.josm.plugins.mapwithai.backend.BoundingBoxMapWithAIDownloader.parseOsm(BoundingBoxMapWithAIDownloader.java:158)
	at org.openstreetmap.josm.plugins.mapwithai.backend.MapWithAIDataUtils.lambda$download$6(MapWithAIDataUtils.java:177)

Check failure on line 70 in josm/plugins/MapWithAI/src/test/unit/org/openstreetmap/josm/plugins/mapwithai/backend/BoundingBoxMapWithAIDownloaderTest.java

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

BoundingBoxMapWithAIDownloaderTest.testThirdPartyConflation()

Unexpected exception thrown: java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because the return value of "java.net.URI.getRawQuery()" is null
Raw output
org.opentest4j.AssertionFailedError: Unexpected exception thrown: java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because the return value of "java.net.URI.getRawQuery()" is null
	at org.openstreetmap.josm.plugins.mapwithai.backend.BoundingBoxMapWithAIDownloaderTest.testThirdPartyConflation(BoundingBoxMapWithAIDownloaderTest.java:69)
Caused by: java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because the return value of "java.net.URI.getRawQuery()" is null
	at org.openstreetmap.josm.plugins.mapwithai.backend.BoundingBoxMapWithAIDownloader.getRequestForBbox(BoundingBoxMapWithAIDownloader.java:136)
	at org.openstreetmap.josm.io.BoundingBoxDownloader.parseOsm(BoundingBoxDownloader.java:211)
	at org.openstreetmap.josm.plugins.mapwithai.backend.BoundingBoxMapWithAIDownloader.parseOsm(BoundingBoxMapWithAIDownloader.java:158)
	at org.openstreetmap.josm.plugins.mapwithai.backend.BoundingBoxMapWithAIDownloaderTest.lambda$testThirdPartyConflation$0(BoundingBoxMapWithAIDownloaderTest.java:70)
	... 1 more

Check failure on line 1 in josm/plugins/MapWithAI/src/test/unit/org/openstreetmap/josm/plugins/mapwithai/backend/MapWithAIRemoteControlTest.java

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

MapWithAIRemoteControlTest.testGetPermissionMessage()

/maps/ml_roads?conflate_with_osm=true&theme=ml_road_vector&collaborator=josm&token=ASb3N5o9HbX8QWn8G_NtHIRQaYv3nuG2r7_f3vnGld3KhZNCxg57IsaQyssIaEw5rfRNsPpMwg4TsnrSJtIJms5m&hash=ASawRla3rBcwEjY4HIY&bbox={bbox}&result_type=road_building_vector_xml?crop_bbox=0.0,0.0,0.001,0.001 ==> expected: <true> but was: <false>
Raw output
org.opentest4j.AssertionFailedError: /maps/ml_roads?conflate_with_osm=true&theme=ml_road_vector&collaborator=josm&token=ASb3N5o9HbX8QWn8G_NtHIRQaYv3nuG2r7_f3vnGld3KhZNCxg57IsaQyssIaEw5rfRNsPpMwg4TsnrSJtIJms5m&hash=ASawRla3rBcwEjY4HIY&bbox={bbox}&result_type=road_building_vector_xml?crop_bbox=0.0,0.0,0.001,0.001 ==> expected: <true> but was: <false>
	at org.openstreetmap.josm.testutils.annotations.BasicWiremock$WireMockExtension.afterEach(BasicWiremock.java:143)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)