-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapillary description translation #77
Comments
Thank you for reporting this! I already implemented this, but currently it seems to skip adding the manifest entries under some circumstances. I'll look into this and fix this for the next release. |
As a temporary fix I committed 325c30d. I'll provide a more thorough fix via the |
Your fix is somehow broken. The Manifest is not fully UTF-8. Maybe a linebreak occuring in the middle of an UTF-8 character? |
@stoecker I really don't want to shift the blame, but this is not my fault. The class I set up a minimal code example to demonstrate that: https://github.com/floscher/gradle-manifest-multibyte-demo In the JAR File specification it says, lines should be no longer than 72 bytes, but it does not say you aren't allowed to cut characters in half. When I agree it is very ugly that Java does it like that by default, but unfortunately the nature of this problem makes it hard to fix it myself easily. |
I feared that may be the case. We usually don't use the UTF-8 stuff directly in the manifest so it never was an issue. So it is a Java bug (or at least a dumb definition). Are you sure Java correctly handles this? Then I simply may adapt the server code to handle it. |
If possible I'd nevertheless prefer proper (human readable) files. Could you at least file a bug report for Java? |
I am pretty sure Java handles this correctly. The Manifest class from Java can read both formats (split inside multibyte character and split between characters). I commented on an existing issue for Gradle about the problem that the Now I'll report this as a separate issue to Gradle (maybe they switch away from the |
I fixed the server code, so it works (even if ugly). |
OK, I reported it now to Oracle and opened a new Gradle issue gradle/gradle#5225. |
For reference I documented behaviour of JOSM reader: https://josm.openstreetmap.de/changeset/13696/josm |
gradle/gradle#5225 (comment) would be a fix for the JDK. |
With the switch of translation system the translated descriptions in manifest are missing.
The text was updated successfully, but these errors were encountered: