FIXUP: JCS -> JCS3 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See JOSM-19208. The JCS package renamed itself to JCS3. Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
|
It seems that we've been working in parallel on the same issue: 92b0654 |
simon04
reviewed
May 11, 2020
| @@ -92,6 +92,7 @@ tasks.processResources { | |||
| archivesBaseName = "wikipedia" | |||
| josm { | |||
| manifest { | |||
| oldVersionDownloadLink 14149, "v1.1.3", new URL("https://josm.gitlab.io/plugin/wikipedia/dist/v1.1.1/wikipedia.jar") | |||
There was a problem hiding this comment.
I missed this line in my commit 92b0654. The URL should be https://josm.gitlab.io/plugin/wikipedia/dist/v1.1.3/wikipedia.jar (not v1.1.1), right?
There was a problem hiding this comment.
Yep. I saw 1.1.1 originally (in releases), and used that, then went back to double-check tags, saw 1.1.3, and only changed one of them.
simon04
added a commit
that referenced
this pull request
May 11, 2020
floscher
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JOSM-19208. (https://josm.openstreetmap.de/ticket/19208)
The JCS package renamed itself to JCS3.
Signed-off-by: Taylor Smock taylor.smock@kaart.com