Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check timelineTypes when all search clicked in timeline Graph view. #130

Merged

Conversation

fukusuket
Copy link
Contributor

@fukusuket fukusuket commented Dec 20, 2022

Hello, thank you for maintaining the tool :)
I found a issue that the graph was not drawn when all clicked in the timeline view, so I fixed it.

What Changed

checking timelineTypes(A flag to identify the table view or graph view) when all clicked in the timeline view.

Motivation and Context

The graph was not drawn when all is clicked(and Graph selected) on the timeline view as follows.
スクリーンショット 2022-12-20 23 24 17

After investigating, I found that createAlltimeline() does not check timelineTypes as follows.
https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1450-L1453

On the other hand, it is checked in searchTimeline() as follows.
https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1475-L1479

So, I fixed that checking timelineTypes in createAlltimeline().

Evidence

After fixing it, I confirmed that graph is drawn when all clicked.
スクリーンショット 2022-12-20 23 01 11

I would appreciate it if you could confirm it🙏

@fukusuket fukusuket changed the title fix: check timelineTypes when timeline all search fix: check timelineTypes when all search clicked in timeline view. Dec 21, 2022
@fukusuket fukusuket changed the title fix: check timelineTypes when all search clicked in timeline view. fix: check timelineTypes when all search clicked in timeline Graph view. Dec 21, 2022
@shu-tom shu-tom merged commit 84d0a72 into JPCERTCC:master Nov 14, 2023
@shu-tom
Copy link
Member

shu-tom commented Nov 14, 2023

Thank you!

@fukusuket fukusuket deleted the fix-timeline-all-search-not-draw-graph branch November 14, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants