Zulu coda test and refactor #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create all templates will have to be refactored to by using async each series in order to be able to add callback which will be called once everything has been completed! ✊
zulucoda
force-pushed
the
zulu-coda-test-and-refactor
branch
from
54c55fe
to
776f0a7
Compare
…rydom/Generate-Redux-Code into zulu-coda-test-and-refactor
zulucoda
commented
Feb 25, 2018
src/generator-utilities.js
Outdated
| @@ -141,7 +141,7 @@ function removeComments(s) { | |||
| return s.replace(/([\s\S]*?)\/\*[\s\S]*?\*\//g, '$1'); | |||
| } | |||
|
|
|||
| function createTemplate(directory, placeholderNames, omitComments) { | |||
| function createTemplate(directory, placeholderNames, omitComments, callback) { | |||
There was a problem hiding this comment.
Dude this breaks test
There was a problem hiding this comment.
it should be return callback(err, 'code generated from template');
|
its cool, I fixed the merge issue |
… refactored to use a callback so that it can be test friendly ✊
|
okay great back to green 👍 |
|
The one test doesn't clean up after itself. We'll have to fix that first. We'll also have to write some |
|
Yeah, finally all green 👍 |
…rydom/Generate-Redux-Code into zulu-coda-test-and-refactor
…an error because of the throw statement)
…rydom/Generate-Redux-Code into zulu-coda-test-and-refactor
… called after writing to file ✊
|
ok cool build is green, lets get this ONE merged 👍 |
Closed
|
you gonna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Test PR clone this REPO: https://github.com/zulucoda/Generate-React-Code-PR-Test