Fix label for attribute #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPeer264
approved these changes
Jul 23, 2019
| @@ -80,6 +80,11 @@ const replaceHtml = (code, opts = {}) => { | |||
| selectorType = '#'; | |||
| } | |||
|
|
|||
| if (node.tagName === 'label' && attr.name === 'for') { | |||
There was a problem hiding this comment.
Could have placed this as || in the if before. But ok for me :)
|
@X-Ryl669 seems like one test case is failing |
|
I don't know why the test failed (maybe you've tested against a different master than mine?). I've rebased on the current master and all tests are good for me. Unless stated otherwise, I'll rebase on this one for the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #87.
This fixes the missing renaming for
label forattribute since this also expect an id (usually from aninput)