Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: custom type (closes #31) #76

Merged
merged 5 commits into from
May 4, 2019
Merged

Feat: custom type (closes #31) #76

merged 5 commits into from
May 4, 2019

Conversation

JPeer264
Copy link
Owner

(ref: #31)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 99.531% when pulling 862f9a9 on feat/ustom-type into 54ea475 on master.

@coveralls
Copy link

coveralls commented Mar 27, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling af2d0d4 on feat/ustom-type into c14a9c3 on master.

@yordis
Copy link

yordis commented Apr 10, 2019

I would do feat(TICKET-NUMBER) ... instead of creating new types for this.

@JPeer264
Copy link
Owner Author

@yordis this is actually already implemented as scope

@JPeer264
Copy link
Owner Author

Actually what you suggested works too and is also imo much better to read. Unfortunately different companies have different rules - and e.g.: PRE-21: this is a new commit is one of them

@yordis
Copy link

yordis commented Apr 10, 2019

@JPeer264 but then people can't assume the tags and other things from the type of the commit.

For the most part, that information is random metadata that you can't rely on.

This is why I think is better to put it as scope (since they kind of are)

@JPeer264
Copy link
Owner Author

I agree to 100% on this.

But still there are projects where this needs to be done (as some of the projects I am working on have this kinda rule). I guess I'll append your suggested method to the readme as well.

Copy link
Collaborator

@aichbauer aichbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JPeer264 JPeer264 merged commit 0435a16 into master May 4, 2019
@JPeer264 JPeer264 deleted the feat/ustom-type branch May 4, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants