-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: custom type (closes #31) #76
Conversation
I would do |
@yordis this is actually already implemented as |
Actually what you suggested works too and is also imo much better to read. Unfortunately different companies have different rules - and e.g.: |
@JPeer264 but then people can't assume the tags and other things from the type of the commit. For the most part, that information is random metadata that you can't rely on. This is why I think is better to put it as scope (since they kind of are) |
I agree to 100% on this. But still there are projects where this needs to be done (as some of the projects I am working on have this kinda rule). I guess I'll append your suggested method to the readme as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(ref: #31)