Skip to content

Commit

Permalink
Refactor inspectContainer() and add commit(), removeImage() (eclipse-…
Browse files Browse the repository at this point in the history
…che#4085)

Adds commit() and removeImage() implementations to
OpenShiftConnector. This requires some refactoring of existing
methods (mostly refactoring repeated processes into their own
methods -- e.g. creating an ImageStreamTag and getting image
info from a tag).

Additionally, refactors inspectContainer() method to remove
a call to DockerConnector, instead obtaining the same information
from what's available through the OpenShift API. This fixes an
issue where the IP address of a workspace was unavailable from
the ContainerInfo returned by DockerConnector.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
  • Loading branch information
amisevsk authored and l0rd committed Feb 11, 2017
1 parent d3aeefe commit c0560e8
Show file tree
Hide file tree
Showing 4 changed files with 536 additions and 147 deletions.
Expand Up @@ -281,6 +281,7 @@ public void destroy() throws MachineException {
try {
docker.removeImage(RemoveImageParams.create(image).withForce(false));
} catch (IOException ignore) {
LOG.error("IOException during destroy(). Ignoring.");
}
}

Expand Down

0 comments on commit c0560e8

Please sign in to comment.