Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.84 #67

Merged
merged 1 commit into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "fratch-ui",
"version": "1.1.83",
"version": "1.1.84",
"repository": {
"type": "git",
"url": "https://github.com/JorgeRojo/fratch-ui.git"
Expand Down
9 changes: 6 additions & 3 deletions src/components/Form/InputText/InputText.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ const InputText = forwardRef<HTMLInputElement, InputTextProps>(
(
{
className,
cleanable,
cleanerClassName,
disabled,
id,
onBlur,
onChange,
onClean,
Expand All @@ -20,10 +22,9 @@ const InputText = forwardRef<HTMLInputElement, InputTextProps>(
onKeyDownCapture,
placeholder,
readOnly,
title,
type = 'text',
value,
title,
cleanable,
}: InputTextProps,
ref
) => {
Expand Down Expand Up @@ -53,6 +54,8 @@ const InputText = forwardRef<HTMLInputElement, InputTextProps>(
return (
<div className={c(styles.input_wrapper, className)}>
<input
id={id}
name={id}
className={c(styles.input)}
disabled={disabled}
onBlur={onBlur}
Expand All @@ -63,8 +66,8 @@ const InputText = forwardRef<HTMLInputElement, InputTextProps>(
placeholder={placeholder}
readOnly={readOnly}
ref={setInnerRef}
type={type}
title={title}
type={type}
/>
{cleanable && (
<button
Expand Down
7 changes: 4 additions & 3 deletions src/components/Form/InputText/InputTextProps.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
export interface InputTextProps {
className?: string;
cleanable?: boolean;
cleanerClassName?: string;
disabled?: boolean;
id?: string;
onBlur?: (event: React.FocusEvent<HTMLInputElement>) => void;
onChange?: (event?: React.ChangeEvent<HTMLInputElement>) => void;
onClean?: (element?: HTMLInputElement) => void;
onClick?: (event: React.MouseEvent<HTMLInputElement>) => void;
onFocus?: (event: React.FocusEvent<HTMLInputElement>) => void;
onClean?: (element?: HTMLInputElement) => void;
onKeyDownCapture?: (event: React.KeyboardEvent<HTMLInputElement>) => void;
placeholder?: string;
readOnly?: boolean;
title?: string;
type?: 'text' | 'password' | 'email' | 'number' | 'tel' | 'url' | 'search';
value?: string;
title?: string;
cleanable?: boolean;
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
border-left: var(--ft-form-item-border);
border-top: var(--ft-form-item-border);
border-bottom: var(--ft-form-item-border);
padding: var(--ft-form-item-padding-y);
padding: 0 16px;
white-space: nowrap;
border-radius: var(--ft-form-item-border-radius) 0 0
var(--ft-form-item-border-radius);
Expand Down
15 changes: 13 additions & 2 deletions src/components/Form/LeftLabeledField/LeftLabeledField.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { Meta, StoryObj } from '@storybook/react';

import Select from '../Select/Select';
import { SelectOption } from '../Select/SelectProps';
import LeftLabeledField from './LeftLabeledField';

const meta = {
Expand All @@ -16,9 +17,19 @@ const meta = {
export default meta;
type Story = StoryObj<typeof LeftLabeledField>;

const labelId = 'labelId';
const options: SelectOption<string>[] = [
{ label: 'Option 1', value: '1' },
{ label: 'Option 2', value: '2' },
];

export const Docs: Story = {
args: {
label: <label>Label</label>,
field: <Select options={[]} />,
label: (
<label style={{ background: '#ccc', padding: '8px' }} htmlFor={labelId}>
Label text...
</label>
),
field: <Select id={labelId} searchable options={options} />,
},
};
28 changes: 15 additions & 13 deletions src/components/Form/Select/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,24 +44,24 @@ function filterOptionByText<T>(text: string) {
}

const useHideOnClickedOutside = ({
id,
uid,
setVisible,
}: {
id: string;
uid: string;
setVisible: React.Dispatch<React.SetStateAction<boolean>>;
}): void => {
// hide options list when clicked outside
useEffect(() => {
const handleDocumentClick = (event: MouseEvent): void => {
if (!isAscendantEvenTargetByID(event, id)) {
if (!isAscendantEvenTargetByID(event, uid)) {
setVisible(false);
}
};
window.document.body.addEventListener('click', handleDocumentClick);
return () => {
window.document.body.removeEventListener('click', handleDocumentClick);
};
}, [id, setVisible]);
}, [uid, setVisible]);
};

const useHideOnTriggerDOMRectChange = ({
Expand Down Expand Up @@ -185,16 +185,17 @@ function Select<T>({
className = '',
cleanable = false,
disabled = false,
id,
noResultsElement,
onChange,
onClean,
options,
placeholder = '',
searchable = false,
value,
triggerElementRef,
value,
}: SelectProps<T>): JSX.Element {
const [id] = useState<string>(uuid());
const [uid] = useState<string>(uuid());
const newTriggerRef = useRef<HTMLInputElement>(null);
const triggerRef = triggerElementRef ?? newTriggerRef;
const [selectedLabel, setSelectedLabel] = useState<string>('');
Expand All @@ -205,13 +206,13 @@ function Select<T>({
useState<SelectOption<T>[]>(options);

useEffect(() => {
selectInstances.set(id, {
selectInstances.set(uid, {
setVisible,
});
return () => {
selectInstances.delete(id);
selectInstances.delete(uid);
};
}, [id]);
}, [uid]);

// set filtered options when options changes
useEffect(() => {
Expand Down Expand Up @@ -277,7 +278,7 @@ function Select<T>({
if (!disabled && triggerRef.current) {
// hide other select instances
selectInstances.forEach((instance, key) => {
if (key !== id) {
if (key !== uid) {
instance.setVisible(false);
}
});
Expand All @@ -304,7 +305,7 @@ function Select<T>({
}
}, [disabled]);

useHideOnClickedOutside({ id, setVisible });
useHideOnClickedOutside({ uid, setVisible });

useHideOnTriggerDOMRectChange({
setVisible,
Expand All @@ -315,12 +316,13 @@ function Select<T>({

return (
<div
id={id}
id={uid}
className={c(className, styles.select, disabled ? styles.disabled : '')}
>
<div className={c(styles.controls)}>
<div>
<InputText
id={id}
title={selectedLabel}
ref={triggerRef}
className={c(styles.trigger)}
Expand Down Expand Up @@ -352,7 +354,7 @@ function Select<T>({
visible={visible}
/>,
document.body,
id
uid
)}
</div>
);
Expand Down
3 changes: 2 additions & 1 deletion src/components/Form/Select/SelectProps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ export interface SelectProps<T> {
className?: string;
cleanable?: boolean;
disabled?: boolean;
id?: string;
noResultsElement?: React.ReactNode;
onChange?: (value?: T) => void;
onClean?: () => void;
options: SelectOption<T>[];
placeholder?: string;
searchable?: boolean;
value?: T;
triggerElementRef?: React.RefObject<HTMLInputElement>;
value?: T;
}