Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleModel should be released too #138

Closed
sbordes opened this issue Nov 20, 2014 · 0 comments
Closed

SimpleModel should be released too #138

sbordes opened this issue Nov 20, 2014 · 0 comments
Assignees
@sbordes
Labels
bug
Milestone
8.0.1

Comments

@sbordes
Copy link
Member

sbordes commented Nov 20, 2014

see #124
When the simplemodel root node is detached from its parent (and so from the scene), the Model.release method should be called.

It was already done in AbstractView and FXMLModel
@sbordes sbordes self-assigned this Nov 20, 2014
@sbordes sbordes added this to the 7.7.6 milestone Nov 20, 2014
@sbordes sbordes added the bug label Nov 20, 2014
sbordes added a commit that referenced this issue Nov 22, 2014
@sbordes
Fix #138 When the simplemodel root node is detached from its parent (and
c7b7b36 
so from the scene), the Model.release method should be called.
@sbordes sbordes closed this as completed Nov 23, 2014
sbordes added a commit that referenced this issue Mar 17, 2015
@sbordes
Fix #138 When the simplemodel root node is detached from its parent (and
7d30ae0 
so from the scene), the Model.release method should be called.

Conflicts:
	org.jrebirth.af/core/src/main/java/org/jrebirth/af/core/ui/simple/AbstractSimpleObjectModel.java
@sbordes sbordes modified the milestones: 8.0.1, 7.7.6 Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordes sbordes

Labels
bug
Projects
None yet
Milestone
8.0.1
Development

No branches or pull requests
1 participant
@sbordes