Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String -> Str #435

Merged
merged 2 commits into from
Jan 5, 2023
Merged

String -> Str #435

merged 2 commits into from
Jan 5, 2023

Conversation

JSAbrahams
Copy link
Owner

@JSAbrahams JSAbrahams commented Jan 4, 2023 •
edited
Loading

Relevant issues

Summary

  • String -> Str.
  • Streamline some format! calls

@JSAbrahams JSAbrahams added the enhancement: check New feature in the type check module label Jan 4, 2023
@JSAbrahams JSAbrahams added this to the v0.3.6 | Dictionaries milestone Jan 4, 2023
@JSAbrahams JSAbrahams self-assigned this Jan 4, 2023
@JSAbrahams JSAbrahams changed the title String -> Str String -> Str Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023 •
edited
Loading

Codecov Report

Merging #435 (98c5092) into develop (75a5ee1) will increase coverage by 0.01%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##           develop     #435      +/-   ##
===========================================
+ Coverage    88.33%   88.34%   +0.01%     
===========================================
  Files          110      110              
  Lines        11999    11997       -2     
===========================================
  Hits         10599    10599              
+ Misses        1400     1398       -2
Impacted Files Coverage Δ
src/check/context/clss/mod.rs 88.65% <ø> (ø)
src/check/context/field/mod.rs 54.28% <0.00%> (ø)
src/check/context/field/union.rs 13.63% <0.00%> (ø)
src/check/context/function/union.rs 13.63% <0.00%> (ø)
src/check/context/parameter/generic.rs 0.00% <0.00%> (ø)
src/check/context/clss/union.rs 80.76% <33.33%> (ø)
src/check/context/clss/generic.rs 93.15% <75.00%> (ø)
src/check/context/function/generic.rs 93.00% <100.00%> (ø)
src/check/context/function/python.rs 96.87% <100.00%> (ø)
src/check/context/mod.rs 96.69% <100.00%> (ø)

@JSAbrahams JSAbrahams marked this pull request as ready for review January 5, 2023 16:12
@JSAbrahams JSAbrahams merged commit 25f6ef4 into develop Jan 5, 2023
@JSAbrahams JSAbrahams deleted the string-to-str branch January 5, 2023 16:18
@JSAbrahams JSAbrahams mentioned this pull request Jan 21, 2023
Merged
JSAbrahams added a commit that referenced this pull request Jan 21, 2023
@JSAbrahams
String -> Str (#435)
57cb174 
* Streamline format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JSAbrahams JSAbrahams

Labels
enhancement: check New feature in the type check module
Projects
None yet
Milestone
v0.3.6 | Dictionaries
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JSAbrahams