Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Mag startup sequence (#332) #334

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Resolve Mag startup sequence (#332) #334

merged 2 commits into from
Oct 20, 2020

Conversation

mvacanti
Copy link
Contributor

Resolve mag startup sequence per #332.

seanmcleod
seanmcleod requested changes Oct 20, 2020
View reviewed changes
Copy link
Member

@seanmcleod seanmcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to delete the counter++; on line 105, otherwise the magnetic variation won't be calculated on the 1st simulation frame, it will only be calculated for the 1st time after 500 frames now.

@mvacanti
Copy link
Contributor Author

Thanks for the catch.... Apologize, I created a new branch for the PR (original issue branch is correct) and manually edited... Updated now.

@mvacanti mvacanti closed this Oct 20, 2020
@mvacanti mvacanti reopened this Oct 20, 2020
@mvacanti mvacanti mentioned this pull request Oct 20, 2020
Merged
@seanmcleod seanmcleod merged commit 9660986 into JSBSim-Team:master Oct 20, 2020
bcoconni pushed a commit that referenced this pull request Oct 20, 2020
@mvacanti @bcoconni
Resolve Mag startup sequence (#332) (#334)
f1d0659 
* Mag startup sequence (#332)
@mvacanti mvacanti deleted the pr-mag-startup-sequence branch October 20, 2020 21:45
@mvacanti mvacanti mentioned this pull request Oct 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmcleod seanmcleod seanmcleod requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvacanti @seanmcleod