Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign change for NED to climb rate #545

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Sign change for NED to climb rate #545

merged 1 commit into from
Dec 23, 2021

Conversation

seanmcleod
Copy link
Member

See - #544

bcoconni
bcoconni approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@bcoconni bcoconni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

This was a miss in the commit e6d383f that fixed the sign of the climb rate more than 10 years ago.

@bcoconni bcoconni merged commit 95b4c86 into JSBSim-Team:master Dec 23, 2021
@seanmcleod seanmcleod deleted the ClimbRateICSign branch December 23, 2021 15:24
@seanmcleod
Copy link
Member Author

This was a miss in the commit e6d383f that fixed the sign of the climb rate more than 10 years ago.

Better late than never 😉

@bcoconni
Copy link
Member

Indeed 😉 Good catch and thanks for the PR!

bcoconni pushed a commit to bcoconni/jsbsim that referenced this pull request Dec 28, 2021
@seanmcleod @bcoconni
Fix the sign for NED climb rate (JSBSim-Team#545)
285cb52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoconni bcoconni bcoconni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanmcleod @bcoconni