Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from FGSurface #907

Merged
merged 2 commits into from
May 13, 2023

Conversation

bcoconni
Copy link
Member

@bcoconni bcoconni commented May 8, 2023

As the title implies, this PR removes the dead code that results from the refactoring made by PR #884.

Some other PR will be submitted to remove the class FGSurface as was mentioned in #884 (comment).

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #907 (2b3d60c) into master (1e19876) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   23.15%   23.14%   -0.01%     
==========================================
  Files         167      167              
  Lines       19639    19603      -36     
==========================================
- Hits         4547     4538       -9     
+ Misses      15092    15065      -27     
Impacted Files Coverage Δ
src/models/FGGroundReactions.cpp 29.62% <ø> (-0.65%) ⬇️
src/models/FGSurface.h 0.00% <ø> (ø)
src/models/FGSurface.cpp 71.05% <100.00%> (+23.10%) ⬆️

@bcoconni bcoconni merged commit 8c13fd6 into JSBSim-Team:master May 13, 2023
27 checks passed
@bcoconni bcoconni deleted the unplug_FGSurface2 branch May 13, 2023 14:27
demonixis pushed a commit to demonixis/jsbsim that referenced this pull request Aug 17, 2023
bcoconni added a commit to bcoconni/jsbsim that referenced this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant