Prismarine: Fixup Entity class #1341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It probably solves it #1331. |
Bundle ReportChanges will increase total bundle size by 281.64kB ⬆️
|
enricoangelon
commented
Apr 23, 2024
| @@ -59,7 +57,7 @@ export class Vector2 { | |||
| * await entity.setZ(10); | |||
| * ``` | |||
| */ | |||
| public setZ(z = 0): void { | |||
| public setZ(z: number): void { | |||
There was a problem hiding this comment.
defaults here may lead to undefined behaviors.
enricoangelon
commented
Apr 23, 2024
enricoangelon
commented
Apr 23, 2024
| @@ -191,6 +192,9 @@ export class Metadata extends MetadataWriter { | |||
| * @TODO: Add missing functions. | |||
| */ | |||
| protected setDefaults(): void { | |||
There was a problem hiding this comment.
As explained in the comments, this whole implementation is wrong.
enricoangelon
commented
Apr 23, 2024
| import type ContainerEntry from '../../inventory/ContainerEntry'; | ||
| import { AddItemActorPacket } from '../../network/Packets'; | ||
| import { Position } from '../../world/Position'; | ||
| import type { World } from '../../world/World'; | ||
| import { Entity } from '../Entity'; | ||
|
|
||
| export class Item extends Entity { |
There was a problem hiding this comment.
Well, an Item is an Entity, but its runtime ID isn't correlated to the Entity one, we will see about this one.
|
uuid is used by the level manager, well partially at least (but that's mostly due to not being completed). Similar to how JE does it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, for the umpteenth time the usual mistake was happening: a lot of logic and not very functional, many useless methods, some even without an actual purpose and also disconnected from the logic of the game. By analyzing the Entity class I was able to find a
uuid, which only players have, resulting in useless logic and not even set up by the game. The Position class must be deterministic, an entity MUST be in a world and in a position, it makes no sense to make the parameters optional, and it only creates damage and UB. A console that acts as a player is something that adds complexity in the code for nothing, sure, they have things in common (a name and that we both send messages), but they are two different concepts... it makes more sense to use a interface. Furthermore, the Entity class must NOT contain netcode in any way, in fact it has been removed. Surely many things will need to be reviewed now, but we will gain stability later on.