Remove async code where it isn't needed #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on I will resolve the conflict from your commit from 10min ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is for removing async codes and promises nesting where it isn't needed/ does nothing.
I didn't change what the code actually does. Now that the code is more readable you might be
able to spot shortcomings in the error management. I leave it up to you to see how you would like to address it.
@filfat I also implemented what we talked about in issue#158.
Now if there is an async callback that sets the event to be canceled, we will actually be able the throw the error.
Next, once this PR is merged, I will make you a proposal on how to cleanly version the EventManager API in an other PR
Best regards,