Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use interface in ColumnDefinition #1367

Closed
sixinli opened this issue Oct 12, 2021 · 1 comment · Fixed by #1778
Closed

use interface in ColumnDefinition #1367

sixinli opened this issue Oct 12, 2021 · 1 comment · Fixed by #1778

Comments

@sixinli
Copy link

sixinli commented Oct 12, 2021

it seems like since https://github.com/JSQLParser/JSqlParser/pull/1274/files#diff-7a533138e54adbf0baac5356d4b7d4a6d192300199ef50eede004f706fd35de3R104 ColumnDefinition accepts ExpressionVisitorAdapter

public void accept(ExpressionVisitorAdapter expressionVisitor) {
expressionVisitor.visit(this);
}

is it possible to have it take one of the interfaces instead?

(just noticed also, they seem to be referencing each other, ExpressionVisitorAdapter#visit calls ColumnDefinition#accept)

@manticore-projects
Copy link
Contributor

manticore-projects commented May 22, 2023

Greetings,

this seems to have been cleaned up with revision commit 288b177 in PR #1778 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants