Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Mapping Columns if they are defined as computed columns in the database schema #23

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

chaks7
Copy link
Contributor

@chaks7 chaks7 commented Mar 11, 2024

Updated mssql-jdbc to 12.6.1.jre11.
Fix for excluding computed columns in the column mapping collection.

@bytefish
Copy link
Collaborator

@vslee Looks good to me. What do you think?

Copy link
Member

@vslee vslee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@bytefish bytefish merged commit f36d91b into JSqlServerBulkInsert:master Mar 12, 2024
@bytefish
Copy link
Collaborator

@chaks7 Thanks for improving the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please exclude computed columns before adding the column to List<SchemaMetaData.ColumnInformation>
3 participants