Fix Broken Coordinate System in Parser #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the PAWLS preprocessor code. Realized my branch of PAWLs had some changes beyond fixing the issuing processing empty pages. There was some dynamic resizing and scaling that was getting the token coordinate system out of sync with the pdf coordinate system. Some of those improvements I made to processing documents were useful, so those open cv improvements should be re-incorporated later for better parsing of bad quality docs. For now, though, the application is working 100% once again :-)
JSv4
changed the title
Codecov Report
@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage 65.50% 65.50%
=======================================
Files 48 48
Lines 2128 2128
=======================================
Hits 1394 1394
Misses 734 734
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JSv4
deleted the
JSv4/reverted-some-of-the-automagic-changes-in-parser-and-restored-full-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue in the app where the tokens did not seem to have the same scale / coordinate system as the page they were on. I realized my branch of PAWLs had some OpenCV image processing improvements beyond fixing the issue processing empty pages. There was some dynamic resizing and scaling that was getting the token coordinate system out of sync with the pdf coordinate system. Some of those improvements I made to processing documents were useful for bad quality docs, so those OpenCV improvements should be re-incorporated later for better parsing of bad quality docs. For now, though, the application is working 100% once again :-)