Add Funsd Export #92
Merged
Add Funsd Export #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen save everything to zip.
…style annotations.
…e was a custom *field* resolver for zip called resolve_zip which no longer took effect once there was no zip field (this is a graphene convention, resolvers are named resolve_[field_name]). Renamed to resolve_file and all is good.
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 69.09% 64.68% -4.42%
==========================================
Files 47 48 +1
Lines 1867 2047 +180
==========================================
+ Hits 1290 1324 +34
- Misses 577 723 +146
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Coverage hit is way too high. Need to write actual tests. |
|
Actually, it's probably better to have this in here. Open a task to write test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major change here is added logic to convert a target annotation to FUNSD format which can then be used to easily train LayoutLMv2, v3, etc. Also fixed an issue with annotation loading and download url generation for exports.
Coverage is going to take a small hit. Will add export tests in the future.