Add cutoff args to batch structure graphs featurizer #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 12 12
Lines 2698 2701 +3
=======================================
+ Hits 2636 2639 +3
Misses 62 62 ☔ View full report in Codecov by Sentry. |
naik-aakash
changed the title
|
Hi @JaGeo, I cannot pin point the issue with codecov yet. It seems both times number of lines missing in modules are reported same . But sometimes total number of lines missing are returned 67 instead of 62 . Maybe need bit more time to check in detail. When codecov passes When codecov reports as failed
Nevertheless, this PR could be merged 😃 |
JaGeo
approved these changes
Feb 26, 2024
|
@JaGeo , I see, seems layouts_dicts.py seems to be the issue. Any idea why this happens? |
|
No, idea, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #228 and #243