Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rofi configs #160

Merged
merged 3 commits into from
May 2, 2024
Merged

Refactor rofi configs #160

merged 3 commits into from
May 2, 2024

Conversation

KKV9
Copy link
Contributor

@KKV9 KKV9 commented Feb 14, 2024

Pull Request

Description

  • 1440p rofi config import from 1080p
  • Main rofi config import from 1080p
  • Long, compact, waybar, wallpaper and zsh import from main
  • Clipboard import from long
  • Rofi beats import from compact
  • Waybar layout import from waybar style
  • Remove duplicated code
  • Reformat in a consistent style

Type of change

  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Hyprland-Dots wiki.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Additional context

There are no UI changes here. Just reformat.
My motivation is to cleanup the code and make it easier to read and modify.

Remove duplicated code by using imports
@JaKooLit
Copy link
Owner

thank you for your continued contributions... however, since there are lots of codes changes, I need to personally check first..

I cant promise to finish checking soon as I dont have much extra time since atm, im really busy at work

@JaKooLit
Copy link
Owner

I have tried this, but I dont see any significant changes?

@JaKooLit JaKooLit merged commit b43151a into JaKooLit:development May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants