Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapped out xrandr to hyprctl monitors in ags overview #293

Merged
merged 1 commit into from
May 21, 2024

Conversation

SherLock707
Copy link
Contributor

Type of change

Please put an x in the boxes that apply:

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • [ x] I have read the CONTRIBUTING document.
  • [ x] My code follows the code style of this project.
  • [ x] My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Hyprland-Dots wiki.
  • I have added tests to cover my changes.
  • [ x] I have tested my code locally and it works as expected.
  • All new and existing tests passed.

@JaKooLit JaKooLit merged commit 388eb72 into JaKooLit:development May 21, 2024
@JaKooLit
Copy link
Owner

JaKooLit commented May 21, 2024

Great job.. it actually feels snappier now than using xrandr

Sparkles Sparkles Sparkles

@JohnRTitor
Copy link
Contributor

Nice

@SherLock707
Copy link
Contributor Author

Great job.. it actually feels snappier now than using xrandr

Awesome! I though of getting rid of it earlier, but totally forgot about hyprctl monitors

@SherLock707
Copy link
Contributor Author

Don't have multi-monitor setup, but we could also make this adapt to any monitor size if we can get active/focused monitor id.

@JaKooLit
Copy link
Owner

Great job.. it actually feels snappier now than using xrandr

Awesome! I though of getting rid of it earlier, but totally forgot about hyprctl monitors

I was actually to forced to go through ags configs earlier after reformatting my Gentoo.... and I noticed about xrandr...

and a simple installing xrandr fixed the issue... my fault.. should have thought of it sooner

@JaKooLit
Copy link
Owner

Don't have multi-monitor setup, but we could also make this adapt to any monitor size if we can get active/focused monitor id.

its what I used before on the wallpaper scripts

@SherLock707
Copy link
Contributor Author

Great job.. it actually feels snappier now than using xrandr

Awesome! I though of getting rid of it earlier, but totally forgot about hyprctl monitors

I can get active workspace's monitor id using hyprctl activeworkspace and use it to get that monitor's dimension. But have to refresh it each time overview is launched, might affect launch-latency I guess.. need to test it out..
Of course need someone with muti-monitor (different resolutions) setup to test it..

@JaKooLit
Copy link
Owner

Great job.. it actually feels snappier now than using xrandr

Awesome! I though of getting rid of it earlier, but totally forgot about hyprctl monitors

I can get active workspace's monitor id using hyprctl activeworkspace and use it to get that monitor's dimension. But have to refresh it each time overview is launched, might affect launch-latency I guess.. need to test it out.. Of course need someone with muti-monitor (different resolutions) setup to test it..

nah I actually felt the the latency right away after switching to hyprctl monitors

I have tried changing scaling on my other monitor to see if affects.. but it looks fine.. it seems abit small now though but its ok... I like it better..

you have the ultra wide version right?

@SherLock707
Copy link
Contributor Author

Great job.. it actually feels snappier now than using xrandr

Awesome! I though of getting rid of it earlier, but totally forgot about hyprctl monitors

I can get active workspace's monitor id using hyprctl activeworkspace and use it to get that monitor's dimension. But have to refresh it each time overview is launched, might affect launch-latency I guess.. need to test it out.. Of course need someone with muti-monitor (different resolutions) setup to test it..

nah I actually felt the the latency right away after switching to hyprctl monitors

I have tried changing scaling on my other monitor to see if affects.. but it looks fine.. it seems abit small now though but its ok... I like it better..

you have the ultra wide version right?

Yup, 3440x1440

@SherLock707
Copy link
Contributor Author

@JaKooLit , you can control scale of it from config/ags/user_options.js

@JaKooLit
Copy link
Owner

yup I know.... but I will try later on... thanks alot bro

@JaKooLit
Copy link
Owner

oh its back to before 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants