Migrate from javax to jakarta #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
reviewed
Sep 21, 2022
| } | ||
| javafx { | ||
| version = "19" | ||
| modules = [ 'javafx.controls', 'javafx.fxml', 'javafx.web', 'javafx.swing' ] |
There was a problem hiding this comment.
How does this now work in the modularized world? Does this adds these modules twice now, once as dependency of afterburner and once as dep of the main application? Are they combined?
In either case, the web and swing modules shouldn't be needed, or are they?
There was a problem hiding this comment.
The project afterburner itself is not modularized, I used the shadow jar plugin. It generates two files:
One with all deps inside and one minimal shadow jar that only contains the classes itself. I used the latter to include it in jabref.
Main reason for this to avoid name clashes with the java ee stuff for the rest api
koppor/jabref#628
Siedlerchr
added a commit
that referenced
this pull request
Sep 22, 2022
* origin/master: Migrate from javax to jakarta (#3) # Conflicts: # build.gradle # src/main/java/com/airhacks/afterburner/injection/Injector.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local build works. JabRef works as well. I dont care about the demo app and the tests