Skip to content

Commit

Permalink
Add saving finished notification
Browse files Browse the repository at this point in the history
  • Loading branch information
koppor committed Nov 23, 2021
1 parent fc0cba2 commit c67c395
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We allowed the user to also preview the available citation styles in the preferences besides the selected ones [#8108](https://github.com/JabRef/jabref/issues/8108)
- We added an option to search the available citation styles by name in the preferences [#8108](https://github.com/JabRef/jabref/issues/8108)
- We added an option to generate bib-entries from ID through a popover in the toolbar. [#4183](https://github.com/JabRef/jabref/issues/4183)
- We added a menu option in the right click menu of the main table tabs to display the library properties. [#6527](https://github.com/JabRef/jabref/issues/6527)
- When a `.bib` file ("library") was saved successfully, a notification is shown

### Changed

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/DialogService.java
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ Optional<ButtonType> showCustomButtonDialogAndWait(Alert.AlertType type, String
<V> Optional<ButtonType> showBackgroundProgressDialogAndWait(String title, String content, StateManager stateManager);

/**
* Notify the user in an non-blocking way (i.e., in form of toast in a snackbar).
* Notify the user in a non-blocking way (i.e., in form of toast in a snackbar).
*
* @param message the message to show.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ private boolean save(Path targetPath, SaveDatabaseMode mode) {
libraryTab.getUndoManager().markUnchanged();
libraryTab.resetChangedProperties();
}
dialogService.notify(Localization.lang("Library saved"));
return success;
} catch (SaveException ex) {
LOGGER.error(String.format("A problem occurred when trying to save the file %s", targetPath), ex);
Expand Down
6 changes: 2 additions & 4 deletions src/main/resources/l10n/JabRef_en.properties
Original file line number Diff line number Diff line change
Expand Up @@ -756,13 +756,11 @@ Save\ before\ closing=Save before closing

Save\ library=Save library
Save\ library\ as...=Save library as...

Saved\ selected\ to\ '%0'.=Saved selected to '%0'.

Saving=Saving
Saving\ all\ libraries...=Saving all libraries...

Saving\ library=Saving library
Library\ saved=Library saved
Saved\ selected\ to\ '%0'.=Saved selected to '%0'.

Search=Search

Expand Down

0 comments on commit c67c395

Please sign in to comment.