Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number of library items not fully displayed -> show as tooltip #10208

Closed
2 tasks done
ghost opened this issue Aug 24, 2023 · 12 comments · Fixed by #10233
Closed
2 tasks done

number of library items not fully displayed -> show as tooltip #10208

ghost opened this issue Aug 24, 2023 · 12 comments · Fixed by #10233
Assignees
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement

Comments

@ghost
Copy link

ghost commented Aug 24, 2023

JabRef version

5.9 (latest release)

Operating system

Windows

Details on version and operating system

Windows 10 22H2

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

I have downloaded 2 databases in BibTeX format: one is an arcade game database (45974 items), the other a game console/computer database (134352)

Please look at screenshot. The number of items in the library is not fully displayed (see at the left). Only 4 digits are displayed, the rest in front of it is gone. Could it be fixed so I see the currect number of items? I know it are A LOT but it's possible to have such a big library :)

afbeelding

afbeelding

Attached are the 2 bib files

games.zip

Appendix

...

Log File
Paste an excerpt of your log file here
@Siedlerchr
Copy link
Member

Fixed in 5.10 dev version

We resolved an issue that cut off the number of group entries when it exceeded four digits. #8797

https://github.com/JabRef/jabref/blob/main/CHANGELOG.md#added

@ghost
Copy link
Author

ghost commented Aug 24, 2023

Sorry!

@ghost ghost closed this as completed Aug 24, 2023
@ghost ghost reopened this Aug 24, 2023
@ghost
Copy link
Author

ghost commented Aug 24, 2023

Can I request a feature (that we can enable/disable in settings) so we can see the full number of items instead of abbreviated? There is space enough to display the extra digits.
It's now displayed as 46k in version 5.10

afbeelding

@Siedlerchr
Copy link
Member

I think a tooltip would be a good idea

@ghost
Copy link
Author

ghost commented Aug 24, 2023

I think a tooltip would be a good idea

yes that's good too! Also for the number of entries in the groups.

@Siedlerchr Siedlerchr added type: enhancement good first issue An issue intended for project-newcomers. Varies in difficulty. labels Aug 24, 2023
@Siedlerchr Siedlerchr changed the title number of library items not fully displayed number of library items not fully displayed -> show as tooltip Aug 24, 2023
@DohaRamadan
Copy link
Contributor

Hello, I'm new to the open-source contributing community, Is this issue a good one for me to start working on?
Note: I'm still trying to understand the codebase.

@ThiloteE
Copy link
Member

@DohaRamadan, yes it is. I will assign you to this issue and move it to reserved. Since I have seen you are interested in another issue also, just give a short notice, if you feel like you only want to continue to work on one of them, then I can unassign you and move the issue back to "free to take" in the projects pages.

@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Aug 26, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@Siedlerchr
Copy link
Member

@DohaRamadan The code for displaying the number would need to be adjusted to additionally display the count as a tooltip:

EasyBind.subscribe(preferencesService.getGroupsPreferences().displayGroupCountProperty(),
shouldDisplayGroupCount -> {
if (text.textProperty().isBound()) {
text.textProperty().unbind();
text.setText("");
}
node.getStyleClass().clear();
if (shouldDisplayGroupCount) {
node.getStyleClass().add("hits");
text.textProperty().bind(group.getHits().map(Number::intValue).map(this::getFormattedNumber));
}
});
text.getStyleClass().setAll("text");

@ghost
Copy link

ghost commented Aug 29, 2023

Can this also be done for each group?

@ghost
Copy link

ghost commented Aug 29, 2023

Thanks a lot for making my feature request!

@DohaRamadan I think this bug is easy to fix too.

#10108

@DohaRamadan
Copy link
Contributor

No problem!
I will check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants