Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour: Groups search - Item assignment #3176

Open
AEgit opened this issue Aug 31, 2017 · 16 comments · Fixed by #8785
Open

Unexpected behaviour: Groups search - Item assignment #3176

AEgit opened this issue Aug 31, 2017 · 16 comments · Fixed by #8785

Comments

@AEgit
Copy link

AEgit commented Aug 31, 2017

JabRef 4.0-dev--snapshot--2017-08-31--master--54e0994ba
Windows 10 10.0 amd64
Java 1.8.0_141

Steps to reproduce:

  1. Search for an group in your database using the new group search feature.
  2. Select an item that is assigned to this group in the main table. The item is now marked in blue.
  3. Search for another group in your database (your currently selected item should not belong to this group).
  4. Select the other group you just searched for in the groups panel.
  5. The item, that previously had been selected in the main table (as indicated by the blue colour and its appearance at the top of the main table items), is no longer selected/visible. Instead the items of the newly selected group are visible.

This behaviour is unexpected, as it does not allow you to quickly assign one item by using the groups search feature (i. e., search group -> select item -> search another group -> assign item to it). Instead you have to assign the group the "old-fashioned" way, i. e. either by drag'n'dropping it to the group of interest OR by using the menu associated with the group OR using both the item and the group search feature.
Just using the groups search feature alone won't do the trick, currently.

@Andrew-Lev
Copy link
Contributor

I took a quick look at this, but am not sure what you're referring to. Do you mean the 'groups interface' and the 'filter groups' feature that's located on the bottom of that pane?

@AEgit
Copy link
Author

AEgit commented Sep 1, 2017

Yes, indeed:
"groups panel" = groups interface
"group search" = filter groups

@Andrew-Lev
Copy link
Contributor

I tried it out by your steps, but dont see that same issue. When I filter and select another group I still see my previous selection and can add it to that group. I did find a defect while looking at this though, when you rename a group through the edit group option it doesnt get renamed in the group editor, only in the actual items that belong to that group.

@AEgit
Copy link
Author

AEgit commented Sep 5, 2017

I've tried it again with:
JabRef 4.0-dev--snapshot--2017-09-02--entry-editor-performance--548537f12
Windows 10 10.0 amd64
Java 1.8.0_141

I can confirm your observation, that the originally selected item is still selected (indicated in blue). The problem, however, is, that this item is not found at the top of the non-group items (displayed in gray), but is found somewhere hidden among other non-group items. This is not a major problem, if you only have a small database, but mine contains several thousand items. Therefore it gets very difficult to find again the item you initially selected (this is also the reason, why I initially thought that the selection had been lost).

@AEgit
Copy link
Author

AEgit commented Oct 29, 2018

This issue persists in:

JabRef 5.0-dev--snapshot--2018-10-28--master--05047f32a
Windows 10 10.0 amd64
Java 1.8.0_191

This issue is potentially connected to the fact that currently non-group items are not shown in the main table (not even in gray; see #4237).

@AEgit
Copy link
Author

AEgit commented Oct 29, 2018

See also the comment here:
#3436 (comment)

@sauliusg
Copy link
Contributor

I can confirm the same behaviour in:
JabRef commit db96f88 (master)
Ubuntu-16.04
Java openjdk version "11.0.4" 2019-07-16
OpenJDK Runtime Environment (build 11.0.4+11-post-Ubuntu-116.04.1)
OpenJDK 64-Bit Server VM (build 11.0.4+11-post-Ubuntu-116.04.1, mixed mode, sharing)

@AEgit
Copy link
Author

AEgit commented Jan 4, 2021

JabRef 5.3--2021-01-04--10180ed
Windows 10 10.0 amd64
Java 14.0.2

The issues as described in #3176 (comment) (with the updates from #3176 (comment)) persist in the current developer version of JabRef.

@AEgit
Copy link
Author

AEgit commented Dec 11, 2021

JabRef 5.4--2021-12-10--eff8073
Windows 10 10.0 amd64
Java 16.0.2
JavaFX 17.0.1+1

This issue reported in in #3176 (comment) (with the updates from #3176 (comment)) persists in the current dev version. Please reopen!

@Siedlerchr Siedlerchr reopened this Dec 11, 2021
@JabRef JabRef deleted a comment from github-actions bot Dec 11, 2021
@Siedlerchr Siedlerchr added this to Normal priority in Features & Enhancements via automation Dec 11, 2021
@JabRef JabRef deleted a comment from github-actions bot Dec 11, 2021
Features & Enhancements automation moved this from Normal priority to Done May 22, 2022
@Siedlerchr
Copy link
Member

Thanks to @LIM0000 this issue is now resolved in the latest development version.

We would like to ask you to use a development build from https://builds.jabref.org/main and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

@AEgit
Copy link
Author

AEgit commented May 30, 2022

JabRef 5.7--2022-05-30--3222878
Windows 10 10.0 amd64
Java 18.0.1
JavaFX unknown

I am afraid, this issue persists in the current development version as far as I can tell. Note also, that it is currently difficult to verify the persistence of the issue, since the floating mode has been lost in the new versions of JabRef (though people are working to get it back: #8206 (comment)). However, since the selected item is even invisible when the "All Entries" group is selected, I reckon this problem persists as described in #3176 (comment)

@AEgit
Copy link
Author

AEgit commented Oct 17, 2023

JabRef 5.11--2023-10-17--8ede31a
Windows 10 10.0 amd64
Java 21-internal
JavaFX 20.0.2+3

I am afraid, this issue persists in the current development version as far as I can tell. Note also, that it is currently difficult to verify the persistence of the issue, since the floating mode has been lost in the new versions of JabRef (though people are working to get it back: #8206 (comment)). However, since the selected item is even invisible when the "All Entries" group is selected, I reckon this problem persists as described in #3176 (comment) with updates from #3176 (comment)

@koppor Can you please re-open this issue?

@Siedlerchr
Copy link
Member

On mac this still looks fine and works as expected:

  1. Select All entries group
  2. Select the desired entries
  3. Right click on the subgroup -> entries are assigned to the group and stay selected

Selected entries stay selected while I right click on the group
grafik

@AEgit
Copy link
Author

AEgit commented Oct 17, 2023

Try with a large database with thousands of entries and groups the following:

Steps to reproduce:

  1. Search for an group in your database using the new group search feature.
  2. Select an item that is assigned to this group in the main table. The item is now marked in blue.
  3. Search for another group in your database (your currently selected item should not belong to this group).
  4. Select the other group you just searched for in the groups panel.
  5. The item, that previously had been selected in the main table (as indicated by the blue colour and its appearance at the top of the main table items), is no longer visible. Instead the items of the newly selected group are visible.

As mentioned in #3176 (comment) the originally selected item is (probably? - I cannot see this in my large database atm) still selected (indicated in blue). The problem, however, is, that this item is not found at the top of the non-group items, but is found somewhere hidden among other non-group items. This is not a major problem, if you only have a small database, but mine contains several thousand items. Therefore it gets very difficult to find again the item you initially selected.

@Siedlerchr
Copy link
Member

Ah now I better understand your problem. Yes, it's a bit cumbersome. But once the item is selected (no matter where, it stays selected) and you filter or select a group it will be added

@AEgit
Copy link
Author

AEgit commented Oct 17, 2023

I am adding here a video to showcase the problem. Note, how the selected item turns "invisible" once the new group is being filtered for. This makes it impossible to drag'n'drop your selected item to another group, which obviously would be something you definitely would like to be able to do with the nice group filtering option.

Groups_search_Item_assignment_JabRef_5.mp4

Given that the issue description as it stands now slightly differs from the original one. Should I open a new bug report in regards or should we re-open this one?

EDIT: And as far as I can tell using "Add selected entries to this group" also does not work, if you follow steps 1 to 5 and then attempt to add the item to the group via the right click menu item. It shows the menu "Add selected entries to this group", but clicking onto it does not add the item to the group.

@koppor koppor reopened this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants