Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide access to dark theme #4130

Closed
tobiasdiez opened this issue Jun 14, 2018 · 7 comments
Closed

Provide access to dark theme #4130

tobiasdiez opened this issue Jun 14, 2018 · 7 comments
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui

Comments

@tobiasdiez
Copy link
Member

In #3891 a dark theme was introduced but so far there is no switch in the preference dialog that allows to choose it.

@tobiasdiez tobiasdiez added type: enhancement ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Jun 14, 2018
@tobiasdiez tobiasdiez added this to ToDo in JavaFX UI Rework via automation Jun 14, 2018
@Siedlerchr
Copy link
Member

Refs #382

@OlzClark
Copy link

Hi, it's my first time contributing to open source. Mind if I give this a shot?

@Siedlerchr
Copy link
Member

Sure, go ahead! Have s look at the contribution guide and get started. Feel free to ask any questions. You can always contact us at our gitter chat

@Siedlerchr Siedlerchr mentioned this issue Jul 18, 2018
8 tasks
@Siedlerchr
Copy link
Member

We could maybe also take a look at jmetro design: https://www.pixelduke.com/jmetro
to get some ideas

@ngrant123
Copy link

Hello,
Is it okay if I work on this? I currently have made an option in the preferences box and the dark theme is implemented correctly. Im about to create a pull request and everything. I might have pushed some code accidentally sorry about that I'm new to open source contributing

@ngrant123
Copy link

Yeah I definetly pushed some stuff to the master branch sorry about that you can delete my commit im creating a pull request rn

JavaFX UI Rework automation moved this from ToDo to Completed Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui
Projects
No open projects
JavaFX UI Rework
  
Completed
Development

No branches or pull requests

4 participants