Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JabRef hangs when trying to merge entries #4348

Closed
erelsgl opened this issue Sep 17, 2018 · 5 comments
Closed

JabRef hangs when trying to merge entries #4348

erelsgl opened this issue Sep 17, 2018 · 5 comments
Assignees
Labels
Projects
Milestone

Comments

@erelsgl
Copy link

erelsgl commented Sep 17, 2018

JabRef 5.0-dev--snapshot--2018-09-13--master--e83680f18
Linux 4.4.0-135-generic amd64
Java 1.8.0_181

Steps to reproduce:

  1. Click on two entries
  2. Right-click and choose "Merge entries".

The merge window is shown, and JabRef is frozen - it must be killed from the command line.
There are no particular log messages.

tobiasdiez added a commit that referenced this issue Sep 18, 2018
Fixes #4348 by reworking the SwingWorker using JavaFX BackgroundTasks.
@Siedlerchr Siedlerchr added this to Needs triage in Bugs via automation Oct 2, 2018
@tobiasdiez tobiasdiez added this to the v5.0 milestone Oct 9, 2018
@tobiasdiez tobiasdiez added the ui label Oct 9, 2018
@pavlapp
Copy link
Contributor

pavlapp commented Oct 16, 2018

Can i look at this problem?

@tobiasdiez
Copy link
Member

Thanks for your interest and for asking if this issue is still up for grabs. However, I've already a PR in the pipeline. Have a look at https://github.com/JabRef/jabref/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22 for other good issues.

@tobiasdiez tobiasdiez self-assigned this Oct 16, 2018
@pavlapp
Copy link
Contributor

pavlapp commented Oct 16, 2018

Ok, how about scrollbar in preferences or dark theme?

@tobiasdiez
Copy link
Member

For the dark theme issue, somebody opened already a PR. But the scrollbar issue is open. I guess the problem lies somewhere in these lines: https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/Base.css#L658-L719

@pavlapp
Copy link
Contributor

pavlapp commented Oct 17, 2018

Okay, I'll look at the scrollbar issue and I'll try solve this. Thank you.

Bugs automation moved this from Needs triage to Closed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Bugs
  
Done
Development

No branches or pull requests

3 participants