Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autogenerate bibtex key not working #4417

Closed
1 task done
springzfx opened this issue Oct 27, 2018 · 4 comments
Closed
1 task done

autogenerate bibtex key not working #4417

springzfx opened this issue Oct 27, 2018 · 4 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects

Comments

@springzfx
Copy link

springzfx commented Oct 27, 2018

In master branch, autogenerate bibtex key not working
Steps to reproduce the behavior:

  1. open Jabref click one entry
  2. press ctrl+G, the confirmation dialog not pop up, and nothing change
  3. from the menu click, it's the same result.

The reason seems to be the confirmation dialog can not up, hope someone to fix this:

boolean overwriteKeys = confirmOverwriteKeys(dialogService);

JabRef version: current master

on
Log File
Paste an excerpt of your log file here
@Siedlerchr Siedlerchr self-assigned this Oct 27, 2018
@Siedlerchr Siedlerchr added this to Needs triage in Bugs via automation Oct 27, 2018
@Siedlerchr
Copy link
Member

Can not confirm this. You have probably enabled the settings Do not overwite keys and disabled the confirmation dialog in the settings "Warn before overwriting keys"

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Oct 27, 2018
@springzfx
Copy link
Author

If disabled the confirmation dialog, it worked as expected.
If enable the confirmation dialog, it won't work, no dialog, no key generated.

peek 2018-10-27 17-36

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Oct 27, 2018
@Siedlerchr
Copy link
Member

Ah okay, now I reproduce it as well. No dialog is shown

Bugs automation moved this from Needs triage to Closed Oct 27, 2018
tobiasdiez pushed a commit that referenced this issue Oct 27, 2018
* Fix generate bibtex key overwrite warning dialog


Fixes #4417

* split up confirm of overwrite and generate keys
put only generate action in background task

* fix checkstyle
@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

Siedlerchr added a commit that referenced this issue Dec 11, 2019
49a1841 Update queen-margaret-university-harvard.csl (#4443)
f841560 Create uni-bern-institut-fur-musikwissenschaft-note.csl (#4401)
6ee503c Create harvard-cite-them-right-all-authors.csl (#4416)
3eceec4 Create harvard-queen-margaret-university.csl (#4441)
3c2299d JEMS.csl (#4436)
bb2f60f Create open-window.csl (#4430)
a908ab4 Nutrition Research Reviews (#4434)
208b693 Bump nokogiri from 1.10.3 to 1.10.4 (#4439)
122a3bb Create nmfs-west-coast-region-national-environmental-policy-act.csl (#4426)
3565fc2 Update tissue-engineering.csl (#4435)
981044e Create transposition.csl (#4375)
73ef6f3 Update tissue-engineering.csl (#4431)
7c4a4cf Update r-and-d-management.csl (#4432)
8628afb Create china-national-standard-gb-t-7714-2015-numeric.csl (#4065)
6ce148c removed spaces in harvard-gesellschaft-fur-bildung-und-forschung-in-europa.csl (#4422)
2af1c6f Create japanese-journal-of-applied-physics.csl (#4425)
fc16579 Add Presses universitaires de Strasbourg style (#4411)
01e58fb Correct spacing issues and documentation link (#4423)
d97cf3f Update geistes-und-kulturwissenschaften-heilmann.csl (#4421)
017947d Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (#4413)
bffe57e Create instituto-de-pesquisas-energeticas-e-nucleares-sp.csl (#4368)
18686d1 Update and rename zeitschrift-fuer-digitale-geisteswissenschaften.csl… (#4410)
bd3a5f6 Final fix for journal article cit plus other updates - uniwersytet-im-adama-mickiewicza-w-poznaniu-wydzial-anglistyki (#4417)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 49a1841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
Archived in project
Bugs
  
Done
Development

No branches or pull requests

2 participants