Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Ranking column feature in main table #5842

Closed
Siedlerchr opened this issue Jan 18, 2020 · 4 comments · Fixed by #9023
Closed

Improve Ranking column feature in main table #5842

Siedlerchr opened this issue Jan 18, 2020 · 4 comments · Fixed by #9023
Assignees
@calixtus
Labels
type: enhancement ui
Projects
JabRef UI Improvements Features & Enhancements Candidates for university projects JabRef Maintainers' Focus

Comments

@Siedlerchr
Copy link
Member

Siedlerchr commented Jan 18, 2020 •
edited

Unranked papers can currently only be ranked through the context menu, unlike read status, relevance, priority, and quality which can be directly toggled. However, after the first ranking, the star bar is shown in the entry list and can be toggled as usual. Although I realise that "empty star bar" = 0 stars and "unranked" are two different states. Following the logic of the other classification attributes, one could just treat these two states as equal, btw tools such as Rythmbox (a GTK-based media player) also handle it like this.

Otherwise, I consider this issue as closable.

Originally posted by @ytzemih in #5834 (comment)
@castro-truelogic
Copy link

Any news about this feature?

@Siedlerchr Siedlerchr added this to Normal priority in JabRef UI Improvements via automation Aug 29, 2020
@Siedlerchr Siedlerchr added this to Normal priority in Features & Enhancements via automation Aug 29, 2020
@tobiasdiez tobiasdiez added this to Medium in Candidates for university projects via automation Sep 1, 2020
@tobiasdiez tobiasdiez moved this from Medium to Small in Candidates for university projects Sep 1, 2020
@calixtus
Copy link
Member

calixtus commented Nov 6, 2020

I'm looking into it.

@calixtus
Copy link
Member

For those who maybe work on that:
You could also change the graphic style of the stars by css (see https://github.com/controlsfx/controlsfx/blob/jfx-13/controlsfx/src/main/resources/org/controlsfx/control/rating.css )

@calixtus
Copy link
Member

This should provide a quick start on the changes necessary: main...koppor:fix-5842

@calixtus calixtus self-assigned this Nov 22, 2021
koppor pushed a commit that referenced this issue Jan 15, 2022
Squashed 'buildres/csl/csl-styles/' changes from f78c707..5563ccc
aaab4e8 
5563ccc Update american-society-for-microbiology.csl (#5842)
19ab80f Merge pull request #5843 from POBrien333/patch-1002
d4a6c6d double trouble
424f7fe in-text >> superscript for T&F ACS style
605253c Merge pull request #5837 from POBrien333/patch-998
eb5417d Merge pull request #5838 from alessandro-gentilini/patch-1
7d2d3f5 Fix typo
9f557b5 Re-indent CSL styles
f587e60 polyglot style
3a3fe2c Create journal-fur-kulturpflanzen-journal-of-cultivated-plants.csl
cb24633 Merge pull request #5826 from dstark/patch-7
2590a6c Merge pull request #5833 from POBrien333/patch-997
5b2481e Create nist-techpubs-jres.csl (#5756)
d2a1a49 Re-indent CSL styles
42c51d1 Update tyndale-bulletin.csl
8dae693 rework style
070586b Localize IEEE dates (#5835)
588fbfe Hopefully fix sorting in CSE author-date (#5834)
1291d72 Update physiotherapy-theory-and-practice.csl
1a64076 New Style for "Neue Kriminalpolitik (Deutsch)" (#5586)
eac93a0 Create physiotherapy-theory-and-practice.csl
2e7a9f6 Merge pull request #5832 from POBrien333/patch-996
4dfad5f Update administrative-science-quarterly.csl
f56db0f Merge pull request #5829 from benthamite/patch-1
526b0b3 Update effective-altruism-wiki.csl
e5b11eb Update effective-altruism-wiki.csl
f2a7301 Update effective-altruism-wiki.csl
5b166c2 Update university-of-roehampton-harvard.csl (#5831)
b231514 Update european-society-of-cardiology.csl (#5519)
dbd902c Re-indent CSL styles
fe8892b Update effective-altruism-wiki.csl
734fa7d Update effective-altruism-wiki.csl
2430a32 Create effective-altruism-wiki.csl
a5101b6 update modern-pathology.csl (#5828)
16f77c8 Update tyndale-bulletin.csl
ea8804e Create the-korean-journal-of-mycology.csl (#5822)
22d8be0 Patch 3 (#5825)
0220ba2 Create jcom.csl (#5819)
cd7b72b Create taylor-and-francis-council-of-science-editors-numeric.csl (#5824)
0033383 Create gomis-senegalese-medicine-thesis.csl (#5774)
b221bcc Create mycobiology.csl (#5821)
d7056f9 Re-indent CSL styles
04ae08b Update tyndale-bulletin.csl
24bd577 Re-indent CSL styles
e08d431 clean up logging
f6ac2a6 Update tyndale-bulletin.csl
e4c07f8 this should be the PR repo name
7f9936c fetch pull request from originating repo
f232f51 Update tyndale-bulletin.csl
e2ae4fc Update tyndale-bulletin.csl
f09f8db Update Sheldon to csl-styles 2.0
a4d7dec re-indent style
a903664 sheldon
7db75fc sheldon
f08dc96 sheldon
35b8bfa sheldon
04e28ca pull req checkout
9c9d061 pull req checkout
9249490 sheldon reindent
9792be6 sheldon reindent
3bced06 reindent & commit
7cc9735 Update styles README and GitHub Actions with 1.0.2 information (#5803)
205c4ea remaining dependents
9458056 fix broken styles
07ba7af fix dependents
e2e7842 Fix term hacks for transition to CSL 1.0.2 (#5801)
5c8c5e9 Replace "sub verbo" with "sub-verbo" (#5799)
7ec637c Fix CSL styles
bcd3054 update to csl/citeproc-ruby 2.0
ec13830 bundle update

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 5563ccc
@calixtus calixtus mentioned this issue Aug 3, 2022
Merged
6 tasks
JabRef UI Improvements automation moved this from Normal priority to Closed Aug 4, 2022
Features & Enhancements automation moved this from Normal priority to Done Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calixtus calixtus

Labels
type: enhancement ui
Projects
Features & Enhancements
Archived in project
JabRef UI Improvements
Archived in project
Candidates for university projects
  
Small
Features & Enhancements
  
Done
JabRef Maintainers' Focus
  
Awaiting triage
JabRef UI Improvements
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rating in main table koppor/jabref
3 participants
@Siedlerchr @calixtus @castro-truelogic