Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing entry type does not work when biblatex source is shown #5905

Closed
systemoperator opened this issue Feb 2, 2020 · 7 comments · Fixed by #5917 or #5966
Closed

Changing entry type does not work when biblatex source is shown #5905

systemoperator opened this issue Feb 2, 2020 · 7 comments · Fixed by #5917 or #5966
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor ui
Projects

Comments

@systemoperator
Copy link
Contributor

systemoperator commented Feb 2, 2020

I am using the latest JabRef 5 master build:
Java 13.0.2
on Ubuntu 16.04

Steps to reproduce the behavior:

  1. Double click an entry in the main table (with e.g. entry type "Article")
  2. Open tab "biblatex source"
  3. Change entry type via the dropdown menu to a different entry type (e.g. entry type "Misc")

Observation: Commonly, the entry type will not change in the biblatex source and will not be updated in the main entry table.

I think in seldom cases the biblatex source has been updated as expected, but I could not reproduce this intended behavor anymore.

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs entry-editor ui labels Feb 2, 2020
@tobiasdiez tobiasdiez added this to Needs triage in Bugs via automation Feb 2, 2020
@tobiasdiez tobiasdiez moved this from Needs triage to Normal priority in Bugs Feb 2, 2020
Bugs automation moved this from Normal priority to Closed Feb 3, 2020
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@systemoperator
Copy link
Contributor Author

systemoperator commented Feb 3, 2020

@tobiasdiez I have tested it. It seems there is still some issue left. Apparently, the first time the entry type gets changed, it does not get changed. (Subsequent changes seem to work.)

Problem case:

  1. Close JabRef (to make it easier to reproduce)
  2. Start JabRef
  3. Open library (or use an already auto-opened library)
  4. Select an entry in the main table
  5. Open tab "biblatex source"
  6. Change entry type via the dropdown menu to a different entry type

Observation: The entry type will not change in the biblatex source and will not be updated in the main entry table and the library is indicated as "modified" (*).

Verification:

a.) Save library with CTRL+S.
b.) Close library
c.) Open previously closed library

Observation: Previous (old) entry type is shown.

If after step 6. the entry type gets changed at least another time (so at least twice) then it works. (Despite the fact, that the main table never gets updated.)

This behavor can also be reproduced with another (untouched!) entry in the main table.

@calixtus
Copy link
Member

calixtus commented Feb 4, 2020

This is really strange. Why is just the first one failing? I'm reopening this Issue.
Thanks for testing anyways.

@calixtus calixtus reopened this Feb 4, 2020
Bugs automation moved this from Closed to Needs triage Feb 4, 2020
@Siedlerchr
Copy link
Member

Does closing/reopening the entry editor help?

@systemoperator
Copy link
Contributor Author

Closing/reopening the entry editor does not help.

@calixtus
Copy link
Member

calixtus commented Feb 5, 2020

I tried to triangulate the problem a bit.
Changing the entry type wont work the first time (but it does from the second time on), but only in the source tab AND if you did not change the entry type from another tab before.
This is getting really obscure...

dawidm added a commit to dawidm/jabref that referenced this issue Feb 20, 2020
Bugs automation moved this from Needs triage to Closed Feb 21, 2020
Siedlerchr pushed a commit that referenced this issue Feb 21, 2020
* Fix: setting BibEntry to "changed" state before setting a new entry type

fixes #5905

* Update changelog
@Siedlerchr
Copy link
Member

Thanks to @dawidm this issue is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor ui
Projects
Archived in project
Bugs
  
Done
4 participants