Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a better solution for defining multiline fields #6448

Closed
Siedlerchr opened this issue May 8, 2020 · 7 comments · Fixed by #9456
Closed

Create a better solution for defining multiline fields #6448

Siedlerchr opened this issue May 8, 2020 · 7 comments · Fixed by #9456
Labels
entry-editor type: code-quality Issues related to code or architecture decisions type: enhancement
Projects
Features & Enhancements Candidates for university projects

Comments

@Siedlerchr
Copy link
Member

Follow up from #6315

  • idea would be to manage this property in the customize entry types dialog
@Siedlerchr Siedlerchr added type: code-quality Issues related to code or architecture decisions type: enhancement labels May 8, 2020
@Siedlerchr Siedlerchr added this to Normal priority in Features & Enhancements via automation May 8, 2020
@Siedlerchr Siedlerchr mentioned this issue May 8, 2020
Closed
@Siedlerchr Siedlerchr mentioned this issue Oct 16, 2020
Merged
5 tasks
@Siedlerchr
Copy link
Member Author

Still a good idea. Should be easily done in the custom entry types dialog

@ilippert
Copy link

ilippert commented Jun 8, 2021

still a good idea - and maybe linked to conversation at #5461

@JabRef JabRef deleted a comment from github-actions bot Jun 8, 2021
@JabRef JabRef deleted a comment from github-actions bot Dec 25, 2021
@Siedlerchr Siedlerchr added this to Medium in Candidates for university projects via automation Apr 5, 2022
@Siedlerchr Siedlerchr moved this from Medium to Small in Candidates for university projects Apr 5, 2022
@a1819644
Copy link

@ilippert @Siedlerchr
Can my team have a look into this issue? We are group of 4 (mix of Bachelors and Masters Students) from University of Adelaide. Also, if possible, would you be able to re-describe the whole issue? I have already read connected threads and right now everything is pretty much scattered in my mind.

@JustinNgu18

@Siedlerchr
Copy link
Member Author

In JabRef some fields are defined as single line, e.g. author title and others are defined as multiline, e.g. abstract, comment.
In the linked PR I created a kind of hacky solution to enable multiline for other (custom) fields as well. "Do not wrap fields" option

Solution would be cool to change the option (e.g. multiline) in the custom entry type dialog. In addition, it should be possible to select the type of the field, e.g. if the field holds persons or keywords.

Comment from @tobiasdiez in the linked PR

It's indeed a bit hacky. I like your idea to make this configurable since this is only one instance where people add a new field and require a certain type of action (e.g. what if I add a new "persons" field, or a new "keywords" field?). Thus having an option to specify the type of a field would be good.

@a1819644 a1819644 mentioned this issue Apr 22, 2022
Open
@JustinNgu18
Copy link

Is the goal here to allow the user to choose whether to use a single line or multiline for custom entry type dialog?

@koppor
Copy link
Member

koppor commented Oct 14, 2022

@JustinNgu18 Yes.

@Freeman6475 Freeman6475 mentioned this issue Dec 15, 2022
Merged
6 tasks
@koppor
Copy link
Member

koppor commented Dec 17, 2022

Please also have in mind to make clear what is meant by "Do not wrap the following fields when saving" in the preferences

See https://discourse.jabref.org/t/set-entry-preview/3393/9?u=koppor

Siedlerchr added a commit to Freeman6475/jabref that referenced this issue Dec 22, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-JabRef#6448
06aa986 
* upstream/main: (120 commits)
  Enable groups drag'n'drop to new library (JabRef#9460)
  Update MacOS jabrefHost.py to find local installs (JabRef#9487)
  Fix remember last open valid library with empty new one (JabRef#9489)
  Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486)
  Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485)
  New Crowdin updates (JabRef#9483)
  Add log for ignored excepton (JabRef#9302)
  Select Library to import into (JabRef#9402)
  Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476)
  Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478)
  Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479)
  Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477)
  Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480)
  Bibtex month not deprecated (JabRef#9404)
  Show development information\n\n+semver: major
  Release v5.8
  Update external libraries add afterburner fx jabref add jakarta inject
  fix display name for artifact store
  Prepare CHANGELOG for release
  Also trigger on branch arm64mac-release
  ...
Siedlerchr added a commit that referenced this issue Dec 24, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-#6448
129b4f6 
* upstream/main:
  Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (#9493)
Siedlerchr added a commit that referenced this issue Dec 27, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-#6448
7a3a57f 
* upstream/main:
  Bump classgraph from 4.8.152 to 4.8.153 (#9502)
  Bump slf4j-api from 2.0.5 to 2.0.6 (#9501)
  Bump org.beryx.jlink from 2.25.0 to 2.26.0 (#9500)
  Bump lucene-queries from 9.4.1 to 9.4.2 (#9499)
  Add double click on preview style to add/remove from the selected list (#9498)
  Fix no context menu with sorting on all entries group (#9497)
Siedlerchr added a commit that referenced this issue Dec 27, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-#6448
176cd2d 
* upstream/main:
  Update to JDK 19 (#9421)
Siedlerchr added a commit to Freeman6475/jabref that referenced this issue Jan 1, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-JabRef#6448
1f57853 
* upstream/main:
  Fix spaces
  Add missing dots
  Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2
  try to repack deb file (JabRef#9506)
  Fix date parser for year/month (JabRef#9507)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
entry-editor type: code-quality Issues related to code or architecture decisions type: enhancement
Projects
Candidates for University Projects
Archived in project
Features & Enhancements
Archived in project
Candidates for university projects
  
Small
Features & Enhancements
  
Normal priority
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a better solution for define multi line fields Freeman6475/jabref
5 participants
@Siedlerchr @koppor @ilippert @JustinNgu18 @a1819644